[9.x] Handle unicode characters on TrimStrings middleware #40600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
approved these changes
Jan 25, 2022
|
|
|
Can this also remove Word Joiner? See my above comment |
|
@foremtehan <?php
// This file is written in UTF-8.
$words[] = 'a';
$words[] = pack('C*',0xC2,0xA0) . 'a'; // NBSP (No-Break Space)
$words[] = pack('C*',0xE2,0x81,0xA0) . 'a'; // Word Joiner
echo '<meta charset="utf-8">', PHP_EOL;
echo '<table border="1">', PHP_EOL;
foreach ($words as $word) {
echo '<tr>', PHP_EOL;
$value = preg_replace('~^\s+|\s+$~iu', '', $word);
echo '<td>', $value, '</td>', PHP_EOL;
echo '<td>', bin2hex($value), '</td>', PHP_EOL;
echo '</tr>', PHP_EOL;
}
echo '</table>', PHP_EOL;The result is below. NBSP (No-Break Space) Word Joiner |
|
Well technically the word-joiner character is not a space. It could be removed by using this: <?php
// This file is written in UTF-8.
$words[] = 'a';
$words[] = pack('C*',0xC2,0xA0) . 'a'; // NBSP (No-Break Space)
$words[] = pack('C*',0xE2,0x81,0xA0) . 'a'; // Word Joiner
echo '<meta charset="utf-8">', PHP_EOL;
echo '<table border="1">', PHP_EOL;
foreach ($words as $word) {
echo '<tr>', PHP_EOL;
$value = preg_replace('~^[\s\x{2060}]+|[\s\x{2060}]+$~iu', '', $word);
echo '<td>', $word, '</td>', PHP_EOL;
echo '<td>', $value, '</td>', PHP_EOL;
echo '<td>', bin2hex($value), '</td>', PHP_EOL;
echo '</tr>', PHP_EOL;
}
echo '</table>', PHP_EOL;But I am afraid that if we keep sending PR to each occurrence of a undesired character it might be overwhelming for maintainers. Is there a list of non-visible characters that we could use? In the meantime, you can override the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #38117 introduced the ability to other space unicode characters to the
TrimStringsmiddleware.As issue #40577 stated the current implementation conflicts with some other unicode characters which end with the same escape sequence as the NBSP character.
In particular these japanese characters:
E381A0)E383A0)The implementation from PR #38117 causes the
A0sequence to be trimmed, which converts the sequence to an invalid one.This PR:
preg_replaceto trim the spaces using the proper modifiersCloses #40577