8000 [9.x] Fix ThrottleRequestsException by seriquynh · Pull Request #39951 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[9.x] Fix ThrottleRequestsException #39951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 9, 2021
Merged

[9.x] Fix ThrottleRequestsException #39951

merged 1 commit into from
Dec 9, 2021

Conversation

seriquynh
Copy link
Contributor

What is the problem?

Passing $message as null into Symfony\Component\HttpKernel\Exception\HttpException::__construct has been deprecated since symfony v5.3 and will be remove in v6.0. Instead, we have to pass a string (an empty string by default). Visit here for more details.

Therefore, the constructor of ThrottleRequestsException (that also extends HttpException via TooManyRequestsHttpException) now only has to accept $message as string.

@taylorotwell taylorotwell merged commit 985b2cf into laravel:master Dec 9, 2021
@seriquynh seriquynh deleted the fix-throttle-requests-exception branch December 10, 2021 00:28
@otilor otilor mentioned this pull request Jan 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seriquynh @driesvints @taylorotwell
0