[9.x] Modify DatabaseRule to accept Arrayable instance inside where methods #39621

amaelftah · 2021-11-15T19:29:13Z

Resubmission of #39620 cause it's a breaking change

i found that when using the Rule::where or any where methods they only accept arrays ... while the underlying query builder can accept collections too ... so I have modified the implementation and here is an example of before vs after

before

$names = collect(['foo', 'bar']);
$companiesIds = collect([1, 2]);

$request->validate([
    'first_name' => Rule::in($names),
    
     //here we have to chain ->toArray()
    'company' => Rule::exists('companies','id')->wereIn('id', $companiesIds->toArray()); 
]);

after

$names = collect(['foo', 'bar']);
$companiesIds = collect([1, 2]);

$request->validate([
    'first_name' => Rule::in($names),
    'company' => Rule::exists('companies', 'id')->wereIn('id', $companiesIds); //no need to chain ->toArray()
]);

i didn't write tests for that behavior cause i felt i will have to repeat some methods inside or use data providers ValidationExistsRuleTest ... and also the query builder behavior is already been tested ... so if it's ok to duplicate am ok to write them

Modify DatabaseRule to accept Arrayable instance inside where methods

6cda330

taylorotwell merged commit 2534e00 into laravel:master Nov 15, 2021

otilor mentioned this pull request Jan 1, 2022

[9.x] Add config create command #40221

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[9.x] Modify DatabaseRule to accept Arrayable instance inside where methods #39621

[9.x] Modify DatabaseRule to accept Arrayable instance inside where methods #39621

Uh oh!

Uh oh!

Uh oh!

[9.x] Modify DatabaseRule to accept Arrayable instance inside where methods #39621

[9.x] Modify DatabaseRule to accept Arrayable instance inside where methods #39621

Uh oh!

Conversation

Uh oh!

Uh oh!