8000 [9.x] Perform type checking only in stable versions of PHP by nunomaduro · Pull Request #39617 · laravel/framework · GitHub
[go: up one dir, main page]

Skip to content

[9.x] Perform type checking only in stable versions of PHP #39617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

nunomaduro
Copy link
Member

This pull request adjusts the type checking workflow, so type checking gets only done in stable versions of PHP. PHPStan does not seem to support quite well PHP 8.1 yet, and in theory, does not make sense to check types twice.

@taylorotwell taylorotwell merged commit 5dc64fd into master Nov 15, 2021
@taylorotwell taylorotwell deleted the chore/types-only-on-stable-php branch November 15, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0