8000 [8.x] Constraint psr/log version by kylekatarnls · Pull Request #38851 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[8.x] Constraint psr/log version #38851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2021
Merged

[8.x] Constraint psr/log version #38851

merged 1 commit into from
Sep 18, 2021

Conversation

kylekatarnls
Copy link
Contributor
@kylekatarnls kylekatarnls commented Sep 18, 2021 •
edited
Loading

monolog/monolog 2.3.4 now supports psr/log 3.0.0 which has log(...): void; while previous versions used: log(...); making Illuminate\Log\LogManager no longer compatible.

I think we should restrict this on Laravel < 9, then maybe enforce psr/log ^3 for Laravel >= 9 then add the : void return type also in Illuminate\Log\LogManager.

See #38852 for 9.x

@kylekatarnls kylekatarnls mentioned this pull request Sep 18, 2021
Merged
@taylorotwell taylorotwell merged commit 3806a98 into laravel:8.x Sep 18, 2021
@szepeviktor szepeviktor mentioned this pull request Oct 8, 2021
Closed
victorvilella pushed a commit to cdsistemas/framework that referenced this pull request Oct 12, 2021
@kylekatarnls @victorvilella
Constraint psr/log version (laravel#38851)
f899fcb
@adiachenko adiachenko mentioned this pull request Oct 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylekatarnls @taylorotwell
0