[9.x] Improves Support\Collection and Database\Eloquent\Collection type definitions
#38538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
893a2d5 to
f409bbb
Compare
driesvints
reviewed
Aug 25, 2021
This reverts commit d6c4291.
driesvints
reviewed
Aug 25, 2021
Co-authored-by: Dries Vints <dries@vints.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on #38257, this pull request starts the work of introducing serious strong type definitions on Laravel core. What this pull request include:
Support\CollectionandDatabase\Eloquent\Collection.What this pull request does not include:
Database\Eloquent. In other words,collect(['string' => 1])->flip()->all()orcollect()->map()is 100% static analyzable and understood by static analysis tools - PHPStorm + PHPStan +Psalm, but not yetUser::all().As the next step, going to improve the type definitions of
Database\Eloquent. That's only possible now because of the this work we did with collections.