[9.x] Update to Symfony v6 and drop PHP 7.4 support #37941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -508,7 +508,7 @@ public function testHttpsRoutesWithDomains() | |||
|
|
|||
| public function testRoutesWithDomainsThroughProxy() | |||
| { | |||
| Request::setTrustedProxies(['10.0.0.1'], SymfonyRequest::HEADER_X_FORWARDED_ALL); | |||
There was a problem hiding this comment.
this change we could make already on 8.x?
crynobone
added a commit
to orchestral/testbench-core
that referenced
this pull request
Jul 7, 2021
laravel/framework#37941 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
1 task
crynobone
added a commit
to orchestral/canvas
that referenced
this pull request
Jul 7, 2021
laravel/framework#37941 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
added a commit
to orchestral/testbench-core
that referenced
this pull request
Jul 7, 2021
* Update to Symfony v6 and drop PHP 7.4 support laravel/framework#37941 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
This was referenced Jul 13, 2021
X-Coder264
reviewed
Aug 24, 2021
| @@ -15,7 +15,7 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^7.4|^8.0", | |||
| "php": "^8.0", | |||
There was a problem hiding this comment.
@driesvints Shouldn't this change be made in all Illuminate components composer.json too?
There was a problem hiding this comment.
Yep seems I forgot to do that. Can you send in a PR? Otherwise I'll try to do that later this week.
There was a problem hiding this comment.
Sure. I'll send one later today.
lisadeloach63
pushed a commit
to lisadeloach63/testbench-core-Laravel
that referenced
this pull request
Sep 1, 2022
* Update to Symfony v6 and drop PHP 7.4 support laravel/framework#37941 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.