[9.x] Consistent BelongsToMany::firstOrCreate behaviour #37337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
requested changes
May 10, 2021
| { | ||
| if (is_null($instance = $this->related->where($attributes)->first())) { | ||
| $instance = $this->create($attributes, $joining, $touch); | ||
| $instance = $this->create($attributes + $values, $joining, $touch); |
There was a problem hiding this comment.
why + and not array_merge? (they are not the same!)
There was a problem hiding this comment.
@GrahamCampbell I addressed this above
Being consistent with the rest of the codebase for firstOrCreate/firstOrNew, I went with a union of the attributes and values when creating a model instead of using array_merge (despite the documentation saying otherwise).
This was referenced Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From Laravel documentation:
This is the current behaviour for other instances of
firstOrCreate, except for theBelongsToManyrelationship. See below:Being consistent with the rest of the codebase for
firstOrCreate/firstOrNew, I went with a union of the attributes and values when creating a model instead of using array_merge (despite the documentation saying otherwise).