8000 [8.x] Fixes array to string conversion exception when using custom validation messages for size rules by mateusjunges · Pull Request #36885 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[8.x] Fixes array to string conversion exception when using custom validation messages for size rules #36885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

[8.x] Fixes array to string conversion exception when using custom validation messages for size rules #36885

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9c579a
Fixes array to string conversion when using custom validation message…
mateusjunges Apr 6, 2021
ac4aaa6
Apply fixes from styleci
mateusjunges Apr 6, 2021
965179d
Improve solution
mateusjunges Apr 6, 2021
dfa542a
Adding tests
mateusjunges Apr 6, 2021
8a39e35
fix tests
mateusjunges Apr 6, 2021
c09b714
add fixes from styleci
mateusjunges Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@mateusjunges
mateusjunges committed Apr 6, 2021
commit 8a39e359ba695ba1a5f0bec4c7c510a6c06a7da1
2 changes: 1 addition & 1 deletion tests/Validation/ValidationValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,7 @@ public function testCustomValidationLinesForSizeRules()
]
]
]);
$v = new Validator($trans, ['name' => ''], ['name' => 'between:5,20']);
$v = new Validator($trans, ['name' => 'Taylor'], ['name' => 'between:10,20']);
$this->assertFalse($v->passes());
$v->messages()->setFormat(':message');
$this->assertSame('Some custom message here', $v->messages()->first('name'));
Expand Down
0