8000 [7.x] Fix PendingRequest docblock by seriquynh · Pull Request #35057 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[7.x] Fix PendingRequest docblock #35057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2020
Merged

[7.x] Fix PendingRequest docblock #35057

merged 1 commit into from
Nov 2, 2020

Conversation

seriquynh
Copy link
Contributor

The beforeSendingCallbacks property of PendingRequest is initialized as an instance of Collection and aren't changed. So, it's docblock must be marked as \Illuminate\Support\Collection.

@taylorotwell taylorotwell merged commit b1f1d9c into laravel:7.x Nov 2, 2020
@seriquynh seriquynh deleted the fix_docblock branch November 2, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seriquynh @taylorotwell
0