8000 [7.x]: Fix offset error on invalid remember token by ERPedersen · Pull Request #34019 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

[7.x]: Fix offset error on invalid remember token #34019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[7.x]: Fix offset error on invalid remember token #34019

wants to merge 2 commits into from

Conversation

ERPedersen
Copy link
Contributor

Sending a request with an invalidly formed remember token throws an error. This ensures that the error is avoided, and the user will just be logged out, if the remember token contains an invalid format.

@GrahamCampbell
Copy link
Member

Is this bug present on 6.x too?

@ERPedersen
Copy link
Contributor Author

Yes it is

framework/src/Illuminate/Session/Middleware/AuthenticateSession.php

Line 43 in 0fc3711

$passwordHash = explode('|', $request->cookies->get($this->auth->getRecallerName()))[2];

@GrahamCampbell
Copy link
Member

Please send a PR to 6.x instead.

@ERPedersen ERPedersen mentioned this pull request Aug 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
47F2
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ERPedersen @GrahamCampbell @driesvints
0