8000 Fixes for Symfony 3.3 compatibility by jarnovanleeuwen · Pull Request #19404 · laravel/framework · GitHub
[go: up one dir, main page]
Skip to content

Fixes for Symfony 3.3 compatibility #19404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 30, 2017
Merged

Fixes for Symfony 3.3 compatibility #19404

merged 2 commits into from
May 30, 2017

Conversation

jarnovanleeuwen
Copy link
Contributor
@jarnovanleeuwen jarnovanleeuwen commented May 30, 2017 •
edited
Loading

Hi,

It seems that some tests have broken with the release of Symfony 3.3.

Kind regards,
Jarno

@jarnovanleeuwen
Copy link
Contributor Author

Travis with setup=stable is fine. setup=lowest is failing because Composer installs Symfony 3.2. Should composer.json be updated to use version ~3.3 of Symfony's packages?

@taylorotwell
Copy link
Member

Removed that stack trace check because that feels really silly.

@taylorotwell taylorotwell merged commit e176401 into laravel:master May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarnovanleeuwen @taylorotwell
0