[5.3] Let disconnect but don't try again inside transaction #15901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How about this PR @taylorotwell @themsaid? |
|
Was this changed in 5.1? Perhaps we need to fix this there? |
|
It is present in 4.2 as well. It being old makes me have doubts about the PR. |
|
We don't need to care about 4.2 - only security issues. Only 5.1 LTS will get other types of bug fixes. |
|
Is this supposed to replace your other PR? |
|
@taylorotwell Yes, this if accepted can apply to 5.1 too. No need for the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #15865
Not sure if I considered everything. So I am not fixing tests for now.