Update src/Illuminate/Session/Store.php #111
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing the issue #58 If session's lifetime parameter equals to 0 session should expire after browser closes. But it doesn't, it expires immediately. If lifetime is something like 30 mins, session class works as expected. This patch fixes the problem and improves our math knowledge.
|
Fixed. |
gonzalom
pushed a commit
to Hydrane/tmp-laravel-framework
that referenced
this pull request
Oct 12, 2023
Add in asset and secureAsset methods and their dependent class methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue #107
If session's lifetime parameter equals to 0 session should expire
after browser closes. But it doesn't, it expires immediately. If
lifetime is something like 30 mins, session class works as expected.
This patch fixes the problem and improves our math knowledge.