8000 Clarification about rate limiter by stebogit · Pull Request #8804 · laravel/docs · GitHub
[go: up one dir, main page]

Skip to content

Clarification about rate limiter #8804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

stebogit
Copy link
Contributor

It might seem obvious once you get it, but it took me a while (too much... 🤦🏻 ) to realize that the tooManyAttempts method does not increment the attempts count, therefore the code snippet was somewhat misleading.
I think this small change would make super clear how to manually interact with the limiter.

Before:
Screenshot 2023-05-22 at 1 24 29 PM

After:
Screenshot 2023-05-22 at 1 29 00 PM

@taylorotwell taylorotwell merged commit cbaac70 into laravel:10.x May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0