fix: register installed skills in boost.json during add-skill#621
Open
meirdick wants to merge 1 commit intolaravel:mainfrom
Open
fix: register installed skills in boost.json during add-skill#621meirdick wants to merge 1 commit intolaravel:mainfrom
meirdick wants to merge 1 commit intolaravel:mainfrom
Conversation
When `boost:add-skill` downloads a community skill, it calls `boost:update` to sync skills to agent directories. However, `boost:update` checks `Config::hasSkills()` which reads the `"skills"` key from `boost.json`. If the user never ran `boost:install --skills`, this key doesn't exist, so the sync is silently skipped — the skill sits in `.ai/skills/` but never reaches `.claude/skills/`, `.cursor/skills/`, etc. Fix: register the installed skill names in `boost.json`'s `"skills"` array before calling `boost:update`, ensuring the subsequent sync always runs. Fixes laravel#620
Member
|
Okay so if I understood this only happens when you try to install skills without running I'll need to rethink on this one if this is something we should support or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
boost:add-skillnow registers installed skill names inboost.json's"skills"array before callingboost:update.claude/skills/,.cursor/skills/, etc.) always runs, even if the user never previously ranboost:install --skillsProblem
When a user runs
boost:add-skillfor the first time (without having previously enabled skills viaboost:install --skills), skills download to.ai/skills/but never sync to agent directories. The skill is invisible to the agent.Root cause:
boost:updatechecksConfig::hasSkills()→ reads"skills"key fromboost.json→ key doesn't exist →hasSkills()returnsfalse→ sync skipped.Discovered while installing meirdick/growth-product-context — a community skill for product analytics journey discovery.
Fix
Added
registerInstalledSkills()which merges newly installed skill names intoboost.json's"skills"array before callingrunBoostUpdate(). This ensuresConfig::hasSkills()returnstrueand the sync proceeds.Test plan
boost:installwithout--skillson a fresh projectboost.jsonhas no"skills"keyboost:add-skill meirdick/growth-product-contextboost.jsonnow has"skills": ["growth-product-context"].claude/skills/growth-product-context/SKILL.mdexistsboost:add-skillagain with a second skill — verify both are inboost.json🤖 Generated with Claude Code