8000 Refactor codes around language by kyuridenamida · Pull Request #91 · kyuridenamida/atcoder-tools · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor codes around language #91

Merged
merged 6 commits into from
Feb 13, 2019
Merged

Refactor codes around language #91

merged 6 commits into from
Feb 13, 2019

Conversation

kyuridenamida
Copy link
Owner

一つ言語を追加する度に色んなソースを触らないといけないのは大変だと思うので、Languageまわりをリファクタした

@codecov-io
Copy link
codecov-io commented Feb 11, 2019 •
edited
Loading

Codecov Report

Merging #91 into master will increase coverage by 0.67%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   91.47%   92.14%   +0.67%     
==========================================
  Files          42       43       +1     
  Lines        1911     1923      +12     
==========================================

8000
+ Hits         1748     1772      +24     
+ Misses        163      151      -12
Impacted Files Coverage Δ
atcodertools/config/config.py 100% <ø> (ø) ⬆️
atcodertools/tools/submit.py 60.37% <0%> (+7.15%) ⬆️
atcodertools/tools/envgen.py 81.92% <100%> (+0.05%) ⬆️
atcodertools/tools/models/metadata.py 100% <100%> (ø) ⬆️
atcodertools/client/atcoder.py 90.37% <100%> (+0.44%) ⬆️
atcodertools/tools/templates/__init__.py 100% <100%> (ø) ⬆️
atcodertools/codegen/code_style_config.py 93.02% <66.66%> (+7.02%) ⬆️
atcodertools/common/language.py 96.15% <96.15%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f56f69...da7c807. Read the comment docs.

@kyuridenamida kyuridenamida mentioned this pull request Feb 11, 2019
Merged
@kyuridenamida
Copy link
Owner Author

https://github.com/kyuridenamida/atcoder-tools/pull/91/files#diff-28bd5d3ae67684cae890bbbf394c9400
本質はこれです

@kyuridenamida kyuridenamida added this to the 1.1.1 milestone Feb 11, 2019
@kyuridenamida kyuridenamida changed the title Refactor lang WIP: Refactor lang Feb 11, 2019
@kyuridenamida
Copy link
Owner Author

#86 がマージされたらrustの定義を追加する

@kyuridenamida kyuridenamida changed the title WIP: Refactor lang Refactor lang Feb 13, 2019
@kyuridenamida kyuridenamida changed the title Refactor lang Refactor codes around language Feb 13, 2019
@kyuridenamida kyuridenamida self-assigned this Feb 13, 2019
@kyuridenamida kyuridenamida merged commit ccab876 into master Feb 13, 2019
@kyuridenamida kyuridenamida deleted the refactor_lang branch April 17, 2021 10:06
@kyuridenamida kyuridenamida added the dev-env-improvement Not for production, but for dev environment label Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kyuridenamida kyuridenamida

Labels
dev-env-improvement Not for production, but for dev environment
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kyuridenamida @codecov-io
0