8000 Fix #240 Add missing return statement in submit_main by naskya · Pull Request #245 · kyuridenamida/atcoder-tools · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #240 Add missing return statement in submit_main #245

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fix #240 Add missing return statement in submit_main #245

merged 1 commit into from
Sep 14, 2021

Conversation

naskya
Copy link
Contributor
@naskya naskya commented Sep 13, 2021 •
edited
Loading

Why is this change needed?

Please see #240.
(In brief: atcoder-tools submit exits with a non-zero exit code regardless of whether the submission was successful or not.)

What did you implement?

I added return True at the end of the main function in submit.py.

What behavior do you expect?

atcoder-tools submit exits successfully if the submission is successful or the solution does not pass the test (WA, TLE, RE).

@codecov-commenter
Copy link
B57E

Codecov Report

Merging #245 (f7f0673) into stable (882b831) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable     #245      +/-   ##
==========================================
- Coverage   89.73%   89.70%   -0.04%     
==========================================
  Files          62       62              
  Lines        2612     2613       +1     
==========================================
  Hits         2344     2344              
- Misses        268      269       +1
Impacted Files Coverage Δ
atcodertools/tools/submit.py 53.03% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 882b831...f7f0673. Read the comment docs.

@naskya naskya changed the title Fix #240 Fix #240 - Add missing return statement in submit_main Sep 13, 2021
@naskya naskya changed the title Fix #240 - Add missing return statement in submit_main Fix #240 Add missing return statement in submit_main Sep 13, 2021
@kyuridenamida
Copy link
Owner

thanks for the contribution. merging

@kyuridenamida kyuridenamida added this to the 2.9.0 milestone Sep 14, 2021
@kyuridenamida kyuridenamida merged commit 2aa9aa7 into kyuridenamida:stable Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@naskya @codecov-commenter @kyuridenamida
0