[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compile flag to reduce size of static library on windows #3644

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Add compile flag to reduce size of static library on windows #3644

merged 1 commit into from
Sep 3, 2024
+2 −0

Conversation

benjaminwinger
Copy link
Collaborator

See #2520. This doesn't really fix the issue, but it reduced the size from 583MB to 315MB when I compared release builds with it enabled/disabled (evidently the static library size has gone up since that issue was opened). The static library size on Linux, for reference, is currently about 43MB, so it still seems unnecessarily large.

According to the docs this is disabled by default for command line builds, but enabled by default in visual studio. There don't appear to be any downsides of enabling it (it forces you to define functions inline when they are marked as inline, but we should do that anyway).

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: b0aca6d5e63042ec65080bec372bf0796937856b
Branch commit hash: 4c4120004d51026187f9dcedda198a52d3534412

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 647.58 645.67 1.91 (0.30%)
aggregation q28 11632.56 13939.40 -2306.84 (-16.55%)
filter q14 139.78 136.61 3.17 (2.32%)
filter q15 143.24 133.09 10.14 (7.62%)
filter q16 303.45 306.72 -3.27 (-1.07%)
filter q17 447.85 444.56 3.29 (0.74%)
filter q18 1939.65 1893.70 45.95 (2.43%)
fixed_size_expr_evaluator q07 565.30 563.50 1.80 (0.32%)
fixed_size_expr_evaluator q08 789.75 787.72 2.03 (0.26%)
fixed_size_expr_evaluator q09 787.79 785.99 1.80 (0.23%)
fixed_size_expr_evaluator q10 238.89 239.35 -0.46 (-0.19%)
fixed_size_expr_evaluator q11 234.22 233.28 0.95 (0.41%)
fixed_size_expr_evaluator q12 234.04 232.84 1.20 (0.52%)
fixed_size_expr_evaluator q13 1469.34 1469.26 0.08 (0.01%)
fixed_size_seq_scan q23 114.52 114.83 -0.31 (-0.27%)
join q29 695.26 688.20 7.06 (1.03%)
join q30 1480.36 1517.82 -37.45 (-2.47%)
join q31 46.45 47.35 -0.91 (-1.91%)
ldbc_snb_ic q35 3476.95 3484.49 -7.54 (-0.22%)
ldbc_snb_ic q36 128.54 139.48 -10.94 (-7.85%)
ldbc_snb_is q32 12.74 12.84 -0.10 (-0.75%)
ldbc_snb_is q33 85.91 93.99 -8.08 (-8.60%)
ldbc_snb_is q34 95.39 99.70 -4.31 (-4.32%)
order_by q25 127.12 122.69 4.43 (3.61%)
order_by q26 439.08 440.31 -1.23 (-0.28%)
order_by q27 1397.18 1398.48 -1.31 (-0.09%)
scan_after_filter q01 179.53 175.73 3.80 (2.16%)
scan_after_filter q02 152.35 152.83 -0.48 (-0.31%)
shortest_path_ldbc100 q39 56.12 54.50 1.62 (2.98%)
var_size_expr_evaluator q03 2032.49 2035.60 -3.11 (-0.15%)
var_size_expr_evaluator q04 2229.93 2219.78 10.15 (0.46%)
var_size_expr_evaluator q05 2607.97 2604.98 2.99 (0.11%)
var_size_expr_evaluator q06 1363.72 1368.89 -5.16 (-0.38%)
var_size_seq_scan q19 1446.42 1450.20 -3.78 (-0.26%)
var_size_seq_scan q20 3106.56 3118.33 -11.78 (-0.38%)
var_size_seq_scan q21 2417.71 2396.01 21.70 (0.91%)
var_size_seq_scan q22 129.38 129.97 -0.59 (-0.46%)

@github-actions GitHub Actions
Copy link

Benchmark Result

Master commit hash: cf1330d6d9eb64cfca1e2e1c3f38ec21b1e2113a
Branch commit hash: eaf495c9d9a37b1ba827496f0ff0b9638759a048

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 667.19 664.38 2.82 (0.42%)
aggregation q28 11564.72 11131.84 432.87 (3.89%)
filter q14 143.38 141.89 1.50 (1.05%)
filter q15 142.97 143.51 -0.54 (-0.38%)
filter q16 326.03 329.23 -3.20 (-0.97%)
filter q17 466.43 464.14 2.29 (0.49%)
filter q18 1964.22 1989.96 -25.75 (-1.29%)
fixed_size_expr_evaluator q07 668.09 560.67 107.42 (19.16%)
fixed_size_expr_evaluator q08 870.27 779.56 90.71 (11.64%)
fixed_size_expr_evaluator q09 836.34 774.03 62.31 (8.05%)
fixed_size_expr_evaluator q10 344.23 259.92 84.31 (32.43%)
fixed_size_expr_evaluator q11 291.17 254.62 36.55 (14.36%)
fixed_size_expr_evaluator q12 328.35 253.28 75.07 (29.64%)
fixed_size_expr_evaluator q13 1587.39 1495.33 92.06 (6.16%)
fixed_size_seq_scan q23 133.56 136.59 -3.04 (-2.22%)
join q31 13.36 13.17 0.18 (1.39%)
ldbc_snb_ic q35 769.45 755.55 13.90 (1.84%)
ldbc_snb_ic q36 51.51 40.92 10.59 (25.88%)
ldbc_snb_is q32 9.25 9.89 -0.64 (-6.43%)
ldbc_snb_is q33 17.15 18.51 -1.36 (-7.37%)
ldbc_snb_is q34 7.72 9.05 -1.33 (-14.67%)
multi-rel multi-rel-large-scan 2855.86 2920.13 -64.27 (-2.20%)
multi-rel multi-rel-lookup 73.40 66.73 6.67 (9.99%)
multi-rel multi-rel-small-scan 59.81 48.80 11.01 (22.56%)
order_by q25 148.98 147.10 1.88 (1.28%)
order_by q26 464.85 466.22 -1.37 (-0.29%)
order_by q27 1438.80 1431.95 6.86 (0.48%)
scan_after_filter q01 192.34 191.78 0.56 (0.29%)
scan_after_filter q02 178.82 181.47 -2.64 (-1.46%)
shortest_path_ldbc100 q39 75.33 75.70 -0.37 (-0.49%)
var_size_expr_evaluator q03 2080.20 2079.95 0.25 (0.01%)
var_size_expr_evaluator q04 2287.49 2295.57 -8.08 (-0.35%)
var_size_expr_evaluator q05 2617.02 2615.85 1.17 (0.04%)
var_size_expr_evaluator q06 1378.81 1385.06 -6.26 (-0.45%)
var_size_seq_scan q19 1483.49 1480.47 3.02 (0.20%)
var_size_seq_scan q20 3241.13 3216.86 24.28 (0.75%)
var_size_seq_scan q21 2445.85 2449.41 -3.57 (-0.15%)
var_size_seq_scan q22 132.32 132.76 -0.44 (-0.33%)

@codecov Codecov
Copy link
codecov bot commented Aug 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (cf1330d) to head (fc37482).
Report is 13 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3644      +/-   ##
==========================================
- Coverage   84.05%   84.04%   -0.01%     
==========================================
  Files        1330     1330              
  Lines       53126    53126              
  Branches     7400     7401       +1     
==========================================
- Hits        44654    44652       -2     
- Misses       8301     8303       +2     
  Partials      171      171

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminwinger benjaminwinger merged commit d66a38d into master Sep 3, 2024
23 checks passed
@benjaminwinger benjaminwinger deleted the msvc-inline branch September 3, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ray6080 ray6080 ray6080 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaminwinger @ray6080