8000 Read NGINX CRDs and build gateway by sarthyparty · Pull Request #246 · kubernetes-sigs/ingress2gateway · GitHub
[go: up one dir, main page]
Skip to content

Read NGINX CRDs and build gateway #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Read NGINX CRDs and build gateway #246

wants to merge 12 commits into from
+1,123 −145

Conversation

sarthyparty
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds NGINX CRD conversion infra

Does this PR introduce a user-facing change?:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sarthyparty
Once this PR has been reviewed and has the lgtm label, please assign robscott for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 3, 2025
@k8s-ci-robot
Copy link
Contributor
k8s-ci-robot 8000 commented Sep 3, 2025

Hi @sarthyparty. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 3, 2025
@sarthyparty sarthyparty marked this pull request as ready for review September 3, 2025 17:52
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 3, 2025
@sarthyparty sarthyparty force-pushed the nginx-gateway-framework branch from aad6fd0 to 5dab229 Compare September 3, 2025 19:34
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 3, 2025
bjee19
bjee19 suggested changes Sep 3, 2025
View reviewed changes
@sarthyparty sarthyparty requested a review from bjee19 September 4, 2025 23:49
shaun-nx
shaun-nx reviewed Sep 5, 2025
View reviewed changes
shaun-nx
shaun-nx reviewed Sep 5, 2025
View reviewed changes
shaun-nx
shaun-nx reviewed Sep 5, 2025
View reviewed changes
salonichf5
salonichf5 reviewed Sep 5, 2025
View reviewed changes
salonichf5
salonichf5 reviewed Sep 5, 2025
View reviewed changes
sarthyparty and others added 2 commits September 5, 2025 14:26
@sarthyparty @shaun-nx
Update pkg/i2gw/providers/nginx/crds/gateway_builder.go
239a2cc 
Co-authored-by: Shaun <s.odonovan@f5.com>
@sarthyparty @shaun-nx
Update pkg/i2gw/providers/nginx/nginx.go
a6e96eb 
Co-authored-by: Shaun <s.odonovan@f5.com>
@sarthyparty
Copy link
Contributor Author

@rikatz @LiorLieberman This PR is a smaller split PR of the full CRD to Gateway API conversion that I'm trying to add. Is this split PR ok? Its not a full conversion, since I didn't want to drop too big of a PR on you guys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman Awaiting requested review from LiorLieberman

@rikatz rikatz Awaiting requested review from rikatz

@bjee19 bjee19 Awaiting requested review from bjee19

@shaun-nx shaun-nx Awaiting requested review from shaun-nx

@salonichf5 salonichf5 Awaiting requested review from salonichf5

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sarthyparty @k8s-ci-robot @shaun-nx @bjee19 @salonichf5
0