8000 Initial e2e structure by rikatz · Pull Request #240 · kubernetes-sigs/ingress2gateway · GitHub
[go: up one dir, main page]
Skip to content

Initial e2e structure #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Initial e2e structure #240

wants to merge 1 commit into from
+240 −2

Conversation

rikatz
Copy link
Member
@rikatz rikatz commented Aug 29, 2025

What type of PR is this?
/kind test

What this PR does / why we need it:
This is the initial implementation of e2e test. No Github Actions/CI is set yet, nor provider specifics.

Which issue(s) this PR fixes:
Part of #234
Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot
Copy link
Contributor

@rikatz: The label(s) kind/test cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?
/kind test

What this PR does / why we need it:
This is the initial implementation of e2e test. No Github Actions/CI is set yet, nor provider specifics.

Which issue(s) this PR fixes:
Part of #234
Does this PR introduce a user-facing change?:

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 29, 2025
@k8s-ci-robot
8000 Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rikatz
Once this PR has been reviewed and has the lgtm label, please assign youngnick for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 29, 2025
@rikatz
Copy link
Member Author
rikatz commented Aug 29, 2025

/hold

couple of things not working:

  • ingress2gateway is failing to use local files. While we may want to make simple tests against a namespace AND local files, I would say the majority of tests could be just an assessment of local files and this way we need to make the input flag work
  • The provider flag says it is optional, and yet it is required when running the program

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2025
@k8s-ci-robot
Copy link
Contributor

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress2gateway-verify 87f9e29 link true /test pull-ingress2gateway-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

adrianmoisey
adrianmoisey reviewed Aug 30, 2025
View reviewed changes
hack/verify-e2e.sh
@@ -0,0 +1,53 @@
#!/usr/bin/env bash

# Copyright 2014 The Kubernetes Authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dammit copy/pasta

LiorLieberman
LiorLieberman reviewed Sep 3, 2025
View reviewed changes
Makefile
# Run e2e tests
.PHONY: e2e
e2e: $(INGRESS2GATEWAY)
I2G=$(INGRESS2GATEWAY) hack/verify-e2e.sh
Copy link
Member
@LiorLieberman LiorLieberman Sep 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Can we do I2GW?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiorLieberman LiorLieberman LiorLieberman left review comments

@youngnick youngnick Awaiting requested review from youngnick

+1 more reviewer

@adrianmoisey adrianmoisey adrianmoisey left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rikatz @k8s-ci-robot @adrianmoisey @LiorLieberman
0