10BC0 Clarify terminology for gateway TLS by kl52752 · Pull Request #4036 · kubernetes-sigs/gateway-api · GitHub
[go: up one dir, main page]
Skip to content

Clarify terminology for gateway TLS #4036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2025
Merged

Clarify terminology for gateway TLS #4036

merged 1 commit into from
Aug 29, 2025

Conversation

kl52752
Copy link
Contributor
@kl52752 kl52752 commented Aug 27, 2025

What type of PR is this?

/kind gep
What this PR does / why we need it:
The proposed GEP to clarify the naming convention was obsolete
Which issue(s) this PR fixes:

Fixes #
Related to: #3979
Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from candita and gcs278 August 27, 2025 13:31
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 27, 2025
@kl52752
Copy link
Contributor Author
kl52752 commented Aug 27, 2025

/assing @shaneutt @robscott

@shaneutt shaneutt self-assigned this Aug 27, 2025
@shaneutt shaneutt moved this to Review in Release v1.4.0 Aug 27, 2025
@shaneutt shaneutt added this to the v1.4.0 milestone Aug 27, 2025
@shaneutt shaneutt requested a review from youngnick August 27, 2025 17:07
robscott
robscott approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member
@robscott robscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kl52752!

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2025
@kl52752 kl52752 force-pushed the gep-update-tls-terminology branch from 886a0c5 to 4ff3118 Compare August 28, 2025 07:32
@shaneutt shaneutt requested review from shaneutt and snorwin and removed request for gcs278 August 28, 2025 12:58
snorwin
snorwin approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member
@snorwin snorwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kl52752!

@shaneutt shaneutt requested a review from rikatz August 28, 2025 14:15
@robscott
Copy link
Member

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2025
@robscott
Copy link
Member

/hold

Actually will wait for another maintainer - cc @shaneutt @youngnick.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2025
shaneutt
shaneutt approved these changes Aug 28, 2025
View reviewed changes
Copy link
Member
@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kl52752 kl52752 force-pushed the gep-update-tls-terminology branch from 4ff3118 to 1432295 Compare August 29, 2025 09:03
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025
@shaneutt shaneutt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2025
shaneutt
shaneutt approved these changes Aug 29, 2025
View reviewed changes
Copy link
Member
@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kl52752, robscott, shaneutt, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9098973 into kubernetes-sigs:main Aug 29, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from Review to Done in Release v1.4.0 Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robscott robscott robscott approved these changes

@shaneutt shaneutt shaneutt approved these changes

@candita candita Awaiting requested review from candita

@youngnick youngnick Awaiting requested review from youngnick

@rikatz rikatz Awaiting requested review from rikatz

+1 more reviewer

@snorwin snorwin snorwin approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@robscott robscott

@shaneutt shaneutt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Release v1.4.0
Status: Done
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
6 participants
@kl52752 @robscott @k8s-ci-robot @snorwin @shaneutt @youngnick
0