10BC0 docs: update implements page by zirain · Pull Request #3996 · kubernetes-sigs/gateway-api · GitHub
[go: up one dir, main page]
Skip to content

docs: update implements page #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Sep 25, 2025
Merged

docs: update implements page #3996

merged 9 commits into from
Sep 25, 2025

Conversation

zirain
Copy link
Contributor
@zirain zirain commented Aug 15, 2025 •
edited
Loading

…version/project

What type of PR is this?

/kind documentation

What this PR does / why we need it:

  1. fix an issue that implements page show wrong result if there's more than one mode/version/project
  2. add a column to show Core test result

Which issue(s) this PR fixes:

Fixes #3995

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 15, 2025
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 15, 2025
@zirain zirain changed the title fix: implements page show wrong result if there's more than one mode/… fix: implements page show wrong result if there's more than one mode/version/project Aug 15, 2025
@zirain zirain mentioned this pull request Aug 15, 2025
Closed
@zirain zirain changed the title fix: implements page show wrong result if there's more than one mode/version/project docs: update implements page Aug 15, 2025
@arkodg
Copy link
Contributor
arkodg commented Aug 15, 2025 •
edited
Loading

hey @zirain can you add a before and after screenshot, thanks

@zirain
Copy link
Contributor Author
zirain commented Aug 15, 2025

hey @zirain can you add a before and after screenshot, thanks

there's a preview link: https://deploy-preview-3996--kubernetes-sigs-gateway-api.netlify.app/

@zirain
Copy link
Contributor Author
zirain commented Aug 15, 2025

Before:

image image

After:

image image

@arkodg
Copy link
Contributor
arkodg commented Sep 18, 2025

cc @xtineskim

youngnick
youngnick reviewed Sep 23, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 23, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2025
@zirain zirain force-pushed the fix/implements-page branch from 6c7fc70 to 378907a Compare September 23, 2025 02:04
@youngnick
Copy link
Contributor

Yeah, okay, this looks good, thanks @zirain.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: youngnick, zirain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2025
@zirain
Copy link
Contributor Author
zirain commented Sep 23, 2025

@robscott can you take a look? need a lgtm.

@arkodg
Copy link
Contributor
arkodg commented Sep 25, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8f9ee2c into kubernetes-sigs:main 8000 Sep 25, 2025
20 checks passed
@zirain zirain deleted the fix/implements-page branch September 25, 2025 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngnick youngnick youngnick left review comments

@mlavacca mlavacca Awaiting requested review from mlavacca

@robscott robscott Awaiting requested review from robscott

Assignees

@arkodg arkodg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc site show a wrong result about conformance test
4 participants
@zirain @arkodg @youngnick @k8s-ci-robot
0