Add gateway class label to generated objects #3955
Conversation
This proposes adding an optional new label to generated objects. This is useful for general querying, such as "find the total CPU usage of all pods created by <implementation>".
|
overall this looks good to me. Did you socialize this "should" part with other implementations? |
|
is there prior art here of multiple implementations (3 or more) adding this label ? |
Not really, its a chicken an egg. It would be inappropriate for an implementation to use a label scoped under |
Yep, agreed no one should use k8s.io prefixed labels without recognition of this label upstream. @arkodg any major objection for this? looks like it is no effort to add, but could just benefit the users. |
|
no objections from my end, just a little hard to compute ROI atm |
|
Seems reasonable to me. /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: howardjohn, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm Curios if we prefer MAY over SHOULD though. Like, is someone is going to encourage implementors to do that? /hold for deciding on the above, feel free to remove |
|
Yes, I think this is fine. /unhold |
What type of PR is this?
/kind gep
/kind test
What this PR does / why we need it:
This proposes adding an optional new label to generated objects. This is useful for general querying, such as "find the total CPU usage of all pods created by ".
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: