add mesh conformance tests structure and a first test #3729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a263b4 to
4c5db2f
Compare
4c5db2f to
097443b
Compare
howardjohn
reviewed
Apr 7, 2025
097443b to
397e794
Compare
8c0825c to
bfaf5ff
Compare
kflynn
approved these changes
Apr 24, 2025
There was a problem hiding this comment.
With the understanding that this isn't the final end state we want, I think we're good to go ahead and land this one as a stopgap so that we can have some mesh conformance coverage. Thanks, @LiorLieberman!
|
/lgtm |
|
Thanks @LiorLieberman! /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kflynn, LiorLieberman, robscott The full list of commands accepted by this bot can be found here. The pull request proces 8000 s is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 30, 2025
This was referenced Jun 3, 2025
This was referenced Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/area conformance-test
What this PR does / why we need it:
#3581 shows that we have minimal conformance tests coverage.
At KubeCon EU, we agreed that its best to first provide coverage and follow up with framework impro 8000 vements later.
Added the first test for path rewrite, and tested with istio
Which issue(s) this PR fixes:
Related: #3581
Does this PR introduce a user-facing change?:
/cc @youngnick @robscott @mikemorris