chore: rename CRDs from xgroup to XCRDs #3682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
de22754 to
847c091
Compare
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
847c091 to
4a2a5d6
Compare
|
LGTM but looks like it might need another |
and fix some small things. Signed-off-by: Nick Young <nick@isovalent.com>
|
Turned out we needed to delete some generated YAMLs for BackendTrafficPolicy and XBackendTrafficPolicy. Should be fixed now. |
|
Thanks @mlavacca and @youngnick! /lgtm |
|
Did we intend to have both of these?< 8000 /p> Cleaned up in #3691 |
howardjohn
added a commit
to howardjohn/gateway-api
that referenced
this pull request
Mar 19, 2025
* Add ListenerSet to kustomize * Sort alphabetically * Remove duplicate ListenerSet (from kubernetes-sigs#3682)
Nope, thanks for catching this! Opened #3692 |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Mar 19, 2025
* Add ListenerSet to kustomize * Sort alphabetically * Remove duplicate ListenerSet (from #3682)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Prefix the resources Kind belonging to the
gateway.networking.x-k8s.iogroup withX.Which issue(s) this PR fixes:
Fixes #3681
Does this PR introduce a user-facing change?: