ListenerSet APIs + Generated Clients #3588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to pull Into a separate PR |
|
/hold for #3589 |
dprotaso
commented
Feb 3, 2025
|
/hold need to add the Gateway changes |
|
/hold cancel |
Ok - I figured out there's a marker
So we could have a single clientset that has stable and experimental apis - let me know what people prefer |
shaneutt
requested changes
Feb 7, 2025
shaneutt
reviewed
Feb 7, 2025
shaneutt
reviewed
Feb 7, 2025
There was a problem hiding this comment.
I think overall we're heading in a good direction here, but I think we need to reiterate what feels like a more obvious question as I read more: "What is a Gateway after this, really?"
Personally I'll have to think on this quite a bit and come back around to it 🤔
|
Namespace support is in a follow up PR #3632 |
shaneutt
requested changes
Feb 25, 2025
shaneutt
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Thank you @dprotaso for working this one for many months, through issues, discussions, zoom syncs, and PRs. Also thank you for #3632 I think it'll be fantastic if we can get that into 1.3 as well.
Once everyone's current comments are resolved, I think this is ready to move into experimental and start getting feedback from implementations.
/approve
|
LGTM with @robscott's requested changes. |
mlavacca
approved these changes
Feb 26, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, mlavacca, robscott, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
All comments are resolved - PTAL and once this is merged I'll rebase the other PR. |
|
Thanks @dprotaso! /lgtm |
EyalPazz
pushed a commit
to EyalPazz/gateway-api
that referenced
this pull request
Feb 27, 2025
* add listenerset types * adjust GEP to match go type * run deepcopy-gen & register-gen * perform code generation * Add ListenerSetList type * remove TODO for cel validation that allows an optional port * add Gateway allowedListeners property * Add 'None' as an allowable option for FromNamespaces * combine into a single client * fix group name to be x-k8s.io * add a blurb about listener conflict * listener names don't need to be unique across listenersets and gateways * change use of ListenerSet conditions to a MUST requirement * add a Programmed Reason of ParentNotProgrammed * fix typo * parentRef is not optional * add a note about Gateway Listener list MAY drop MinItems=1 requirement * Update GEP to experimental * update GEP metadata * AllowedListeners is no longer a list
EyalPazz
pushed a commit
to EyalPazz/gateway-api
that referenced
this pull request
Feb 27, 2025
* add listenerset types * adjust GEP to match go type * run deepcopy-gen & register-gen * perform code generation * Add ListenerSetList type * remove TODO for cel validation that allows an optional port * add Gateway allowedListeners property * Add 'None' as an allowable option for FromNamespaces * combine into a single client * fix group name to be x-k8s.io * add a blurb about listener conflict * listener names don't need to be unique across listenersets and gateways * change use of ListenerSet conditions to a MUST requirement * add a Programmed Reason of ParentNotProgrammed * fix typo * parentRef is not optional * add a note about Gateway Listener list MAY drop MinItems=1 requirement * Update GEP to experimental * update GEP metadata * AllowedListeners is no longer a list
k8s-ci-robot
pushed a commit
that referenced
this pull request
Mar 4, 2025
* apis: add implementation for GEP-3388 HTTPRoute Retry Budget * fmt and add descriptions for parameters * Move GEP 3388 to Experimental * make generate * Minor change * Require both parameters of RequestRate * Begin fixing Retry description. Add defaults, some validation, in CommonRetryPolicy * Taking the liberty of renaming CommonRetryPolicy to RetryConstraint * Shamelessly copying from backendlbpolicy and backendtlspolicy to conform with api structure * Fleshing out the description for RetryConstraint * refactor codegen scripts to make it easier to generate two clients * Attempting to match the experimental API structure that dprotaso made in #3588 * Delete files that were generated before moving to apisx * undo commenting * Working to fix code gen following merge * Fix api group name * capitalize RFC 2119 keyword * Addressing comments from code review * missing file * fix imports * Modify descriptions; add greater validation * Update apisx/v1alpha2/backendtrafficpolicy.go Co-authored-by: Rob Scott <rob.scott87@gmail.com> * Not complete, but adding CEL tests for backend traffic policy * fix missing retryConstraint in test struct; add tests for invalid config * move to apis/v1alpha1 * add main_test * rename file * fix missing quotes :) * fix CEL condition * move validation message to interval field directly * remove unused apisx/v1alpha2 file * remove more files from before merging experimental api versions --------- Co-authored-by: Dave Protasowski <dprotaso@gmail.com> Co-authored-by: Rob Scott <rob.scott87@gmail.com>
gcs278
added a commit
to gcs278/gateway-api
that referenced
this pull request
Mar 7, 2025
GEP-1713 was previously listed as provisional, but PR kubernetes-sigs#3588 moved it to experimental.
gcs278
added a commit
to gcs278/gateway-api
that referenced
this pull request
Mar 7, 2025
GEP-1713 was previously listed as provisional in the website, but PR kubernetes-sigs#3588 moved it to experimental.
k8s-ci-robot
pushed a commit
that referenced
this pull request
Mar 10, 2025
GEP-1713 was previously listed as provisional in the website, but PR #3588 moved it to experimental.
EyalPazz
pushed a commit
to EyalPazz/gateway-api
that referenced
this pull request
Mar 18, 2025
GEP-1713 was previously listed as provisional in the website, but PR kubernetes-sigs#3588 moved it to experimental.
zirain
reviewed
Apr 4, 2025
| // Gateway. | ||
| NamespacesFromSame FromNamespaces = "Same" | ||
| // No Routes/ListenerSets may be attached to this Gateway. | ||
| NamespacesFromNone FromNamespaces = "None" |
There was a problem hiding this comment.
@dprotaso what's the user case for None?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1713
Merge #3589 beforehand (to make this diff easier)
Note: this required two different client sets because if you try to generate a client set containing the stable group (
gateway.networking.k8s.io) and experimental(gateway.networking.k8s-x.io)client-gen usesgatewaypart from both api groups for naming in the client set and it creates a conflictRelease Note