8000 Spelling by jsoref · Pull Request #3400 · kubernetes-sigs/gateway-api · GitHub
[go: up one dir, main page]
Skip to content

Spelling #3400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 59 commits into from
Feb 12, 2025
Merged

Spelling #3400

merged 59 commits into from
Feb 12, 2025

Conversation

jsoref
Copy link
Contributor
@jsoref jsoref commented Oct 21, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/gateway-api/actions/runs/11444311412#summary-31838911907

The action reports that the changes in this PR would make it happy: https://github.com/jsoref/gateway-api/actions/runs/11444311702#summary-31838912845

It also fixes the labels of a pair of images to match the word actually used

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @jsoref!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added kind/gep PRs related to Gateway Enhancement Proposal(GEP) cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @jsoref. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jsoref
jsoref commented Oct 21, 2024
View reviewed changes
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2025
@jsoref
Copy link
Contributor Author
jsoref commented Jan 19, 2025

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 28, 2025
shaneutt
shaneutt requested changes Feb 11, 2025
View reviewed changes
Copy link
Member
@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the thorough once over of the repositories spelling errors!

I read it all over, and everything here looks good to me except for historical GEP images which were accurate at the time (see comments below).

It occurred to me that would be nice if we could add checks that can run in CI to avoid these getting merged in the first place (however, that doesn't need to be the burden of this PR).

@shaneutt shaneutt added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 11, 2025
@jsoref
spelling: adding
5fad9a6 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: anymore
783e8df 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: approach
68e2a30 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: attached
2ab4845 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: because
016571d 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 11, 2025
@jsoref
Copy link
Contributor Author
jsoref commented Feb 11, 2025

I'm happy to provide a version of this for CI after a version of this merges. It's used by a number majors projects. I'm happy to talk about that on slack/in an issue after this merges.

jsoref added 15 commits February 11, 2025 18:34
@jsoref
spelling: possible
e34f45b 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: preexisting
d10efd8 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: prominence
5798db7 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: protocol
e0a37a3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: recommend
aea9af3 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: referent
d074fdc 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: release
0fb0ec1 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: route-override
fbc1c93 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: stabilizing
95f58b6 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: substituted
390f5d0 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: targeting
1b3c687 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: the
63799af 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: validationutil
02c19d4 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
spelling: which
4e79ea6 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref
Reword simplify prototyping description
8e1a8e5 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
shaneutt
shaneutt approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member
@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/cc @mlavacca @robscott @youngnick for LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsoref, shaneutt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2025
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Feb 12, 2025
@robscott
Copy link
Member

Thanks @jsoref!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
@shaneutt shaneutt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2025
@k8s-ci-robot k8s-ci-robot merged commit d8f2a20 into kubernetes-sigs:main Feb 12, 2025
13 checks passed
@jsoref jsoref deleted the spelling branch February 12, 2025 18:44
EyalPazz pushed a commit to EyalPazz/gateway-api that referenced this pull request Feb 16, 2025
@jsoref @EyalPazz
Spelling (kubernetes-sigs#3400)
0818e6c 
* spelling: adding

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: anymore

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: approach

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: attached

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: because

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: cannot

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: case-insensitive

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: case-sensitive

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: certificate

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: certificates

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: criteria

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: deterministically

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: discoverability

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: docs

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: encapsulated

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: feature

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: filesystem

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: format

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: frankbu

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: github

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: grpc

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: grpcroute

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: has

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: have

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: http-route

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: httpproxy

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: httpredirect

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: https

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: implementation

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: improvements

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: in

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: infrastructure

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: into

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: intuitive

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: its

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: linked

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: maintainers

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: maintenance

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: maximum

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: negotiated

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: networking

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: nonexistent

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: or

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: overridden

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: possible

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: preexisting

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: prominence

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: protocol

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: recommend

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: referent

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: release

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: route-override

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: stabilizing

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: substituted

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: targeting

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: the

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: validationutil

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* spelling: which

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

* Reword simplify prototyping description

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

---------

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@craigbox craigbox mentioned this pull request Mar 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

@mikemorris mikemorris Awaiting requested review from mikemorris

@mlavacca mlavacca Awaiting requested review from mlavacca

@robscott robscott Awaiting requested review from robscott

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsoref @k8s-ci-robot @k8s-triage-robot @robscott @shaneutt
0