10000 Promote GEP-957 to standard channel by frankbu · Pull Request #2777 · kubernetes-sigs/gateway-api · GitHub
[go: up one dir, main page]
Skip to content

Promote GEP-957 to standard channel #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

Promote GEP-957 to standard channel #2777

merged 1 commit into from
Apr 2, 2024

Conversation

frankbu
Copy link
Contributor
@frankbu frankbu commented Feb 16, 2024 •
edited
Loading

What type of PR is this?

/kind gep

What this PR does / why we need it:

GEP-957 should be moved from experimental to standard channel.

Depends on: #2775

Which issue(s) this PR fixes:

Fixes #957

Does this PR introduce a user-facing change?:

Attaching routes to gateways by port number (GEP-957) feature moved to standard channel.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/gep PRs related to Gateway Enhancement Proposal(GEP) labels Feb 16, 2024
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 16, 2024
@youngnick
Copy link
Contributor

Updates #957

@frankbu frankbu mentioned this pull request Mar 28, 2024
Merged
@robscott
Copy link
Member

Thanks @frankbu! With #2775 merged, this is good to go. Will defer to someone else for final LGTM.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 28, 2024
@robscott robscott added this to the v1.1.0 milestone Mar 28, 2024
@kflynn
Copy link
Contributor
kflynn commented Apr 2, 2024

Hit it! 🙂
/approve

mlavacca
mlavacca reviewed Apr 2, 2024
View reviewed changes
Copy link
Member
@mlavacca mlavacca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 2, 2024
@robscott
Copy link
Member
robscott commented Apr 2, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frankbu, howardjohn, kflynn, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6d6a92b into kubernetes-sigs:main Apr 2, 2024
9FB2 gcs278 mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlavacca mlavacca mlavacca left review comments

@shaneutt shaneutt Awaiting requested review from shaneutt

+1 more reviewer

@howardjohn howardjohn howardjohn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mlavacca mlavacca

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/gep PRs related to Gateway Enhancement Proposal(GEP) lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

GEP: Route Port Matching
7 participants
@frankbu @youngnick @robscott @kflynn @k8s-ci-robot @howardjohn @mlavacca
0