docs: AttachedRoutes docs update
#2050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The go comment for the Gateway's AttachedRoutes field has been updated by adding the condition that the Routes need to be accepted to be considered successfully attached to a listener. Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
AttachedRoutes docs update
shaneutt
approved these changes
May 22, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mlavacca, shaneutt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @mlavacca! /lgtm |
|
/cherry-pick release-0.7 |
|
@robscott: new pull request created: #2053 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind documentation
What this PR does / why we need it:
The go comment for the Gateway's AttachedRoutes field has been updated
by adding the condition that the Routes need to be accepted to be
considered successfully attached to a listener.
Which issue(s) this PR fixes:
Fixes #1913
Does this PR introduce a user-facing change?: