-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update image naming scheme, compatibility with ggcr v0.15.2 #289
Conversation
@puerco needs rebase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
This commit modifies the default naming scheme in SPDX packages representing container images. The new scheme will now be the expanded image reference at digest when available. If an image reference is not available, the package name will be sha256:digest as it is now. Signed-off-by: Adolfo García Veytia (Puerco) <puerco@chainguard.dev>
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR modifies the default naming scheme used in SPDX packages when representing container images. The new scheme will now be the expanded image reference @ digest when available. For example the top-level package representing
nginx
will now be:When no reference is available, the name of the package will still be the digest as in
sha256:63547654...
Multi-arch images fronted by the index manifest will be named using the same schema while layers keep the digest naming convention. Here is a sample:
Which issue(s) this PR fixes:
This PR also fixes an incompatibility with go-containerregistro v0.15.x that was preventing updating the library.
Special notes for your reviewer:
/assign @cpanato
Does this PR introduce a user-facing change?