tox target to enforce pep8 #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 94.52% (diff: 100%)@@ master #97 diff @@
==========================================
Files 9 9
Lines 658 658
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 622 622
Misses 36 36
Partials 0 0
|
mbohlool
reviewed
Jan 12, 2017
|
|
||
| [testenv:update-pep8] | ||
| commands = | ||
| {toxinidir}/scripts/update-pep8.sh |
There was a problem hiding this comment.
On thing that is not clear for me is, do we fail if update-pep8.sh change any file on travis? If we don't we should add verify-pep8.sh the same way we have verify in k8s and call that one.
There was a problem hiding this comment.
yes, if you see the update-pep8.sh, we run "git status" and fail if any files need updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help nudge future PR authors to fix style related issues