Introducing __version__ variable #318
Conversation
|
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mbohlool Could you please take a look here? I've signed the CLA, but the process seems to be broken. Linux Foundation helpdesk is just answering with canned answers. Is there a way to do this manually? Thanks! |
|
I don't think there is a way around it. More information along with individual's contact information here: https://github.com/kubernetes/community/blob/master/CLA.md |
|
You can also ask your question in this issue: kubernetes/kubernetes#27796 |
|
Bumping again for the CLA check. |
|
Thanks for the patch. I think this will work most of the time but we can hardcode the version as it only changes when we call sed -i'' "s/^CLIENT_VERSION = .*/CLIENT_VERSION = \\\"${CLIENT_VERSION}\\\"/" "${SCRIPT_ROOT}/../setup.py"it can do the same here too if you only add this line: # The version is auto-updated. Please do not edit.
__version__ = Noneand add this line to the sed -i'' "s/^__version__ = .*/__version__ = \\\"${CLIENT_VERSION}\\\"/" "${CLIENT_ROOT}/__init__.py"what do you think about this solution? |
|
@mbohlool Since you've already got that in place, this is the way to go. I assume |
|
Yes. The process is explained in the release page. |
|
Would be nice if you can squash all commits into one then run update-client.sh script commit its changes separately. This will make sure everything works. If you saw changes to spec versions, that is expected. Commit those too. |
|
Okay, I hope this was right. There where a lot of changed files coming from |
|
You probably need to do a rebase, then the changes will be much less as most of them are already in master. I would revert the auto-update commit, do a rebase and then run the updater again. That should give you a clean change. |
Version information comes from scripts/constants.py and is hard-coded to kubernetes/__init__py by scripts/update-client.sh. __project__ is just hard-coded. Fixes kubernetes-client#317
|
@mbohlool This looks much better! |
|
Thanks for bear with me :) This looks good. |
With the gathered distribution information we are trying to fetch the version number for
kubernetes.__version__.Fixes #317