8000 Set an upper limit on the urllib3 dependency by Tenzer · Pull Request #2417 · kubernetes-client/python · GitHub
[go: up one dir, main page]
Skip to content

Set an upper limit on the urllib3 dependency #2417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set an upper limit on the urllib3 dependency #2417

wants to merge 1 commit into from
+1 −1

Conversation

Tenzer
Copy link
@Tenzer Tenzer commented Jul 8, 2025

What type of PR is this?

/kind bug

What this PR does / why we need it:

With urllib3 2.4.0 stricter certificate validity checks were added when running on Python 3.13+: urllib3/urllib3#3571.

This triggers errors such as the following:

[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Missing Authority Key Identifier

It is however only for users with Kubernetes clusters that have been set up without proper, valid certificates. Notably, this was the case for AWS EKS clusters created with Kubernetes v1.16 and earlier.

Which issue(s) this PR fixes:

Fixes #2394

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@Tenzer
Set an upper limit on the urllib3 dependency
c38eee8 
With urllib3 2.4.0 stricter certificate validity checks were added when running
on Python 3.13+: urllib3/urllib3#3571.

This triggers errors such as the following:

> [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: Missing Authority
> Key Identifier

It is however only for users with Kubernetes clusters that have been set up
without proper, valid certificates. Notably, this was the case for AWS EKS
clusters created with Kubernetes v1.16 and earlier.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 8, 2025
@k8s-ci-robot k8s-ci-robot requested a review from roycaihw July 8, 2025 13:39
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Tenzer
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @Tenzer!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested a review from yliaog July 8, 2025 13:39
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 8, 2025
@Tenzer Tenzer mentioned this pull request Jul 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

urllib3 v2.4.0 on Python 3.13 doesn't work with EKS
2 participants
@Tenzer @k8s-ci-robot
0