8000 add support for attach api call using websockets. by skuda · Pull Request #180 · kubernetes-client/python · GitHub
[go: up one dir, main page]
Skip to content

add support for attach api call using websockets. #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2017
Merged

add support for attach api call using websockets. #180

merged 1 commit into from
Apr 18, 2017

Conversation

skuda
Copy link
Contributor
@skuda skuda commented Apr 18, 2017

Hi,

I needed to use /attach api call, this method exposes the same problem as /exec so I just reused the current solution using websockets.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 18, 2017
@skuda
Copy link
Contributor Author
skuda commented Apr 18, 2017

Check CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 18, 2017
@codecov-io
Copy link
codecov-io commented Apr 18, 2017 •
edited
Loading

Codecov Report

Merging #180 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   94.46%   94.46%           
=======================================
  Files           9        9           
  Lines         668      668           
=======================================
  Hits          631      631           
  Misses         37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fdbd7...5a590f8. Read the comment docs.

@mbohlool mbohlool self-requested a review April 18, 2017 16:52
@mbohlool
Copy link
Contributor

LGTM. Thanks for the contribution.

@mbohlool
Copy link
Contributor

nit: can you squash all commits into one please?

@skuda
Copy link
Contributor Author
skuda commented Apr 18, 2017

Done, sorry, someway 4 spaces where added to an empty line and I fixed it using the webinterface.

@mbohlool mbohlool self-assigned this Apr 18, 2017
@mbohlool mbohlool merged commit 542facb into kubernetes-client:master Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@mbohlool mbohlool

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@skuda @k8s-ci-robot @codecov-io @mbohlool
0