Redo pypi token encryption for travis ci deployment #1100
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
It does not seem like the deploy stage is run.
|
|
Will the deploy stage run on any pull request The deployment is triggered on tag. I think tagging requires write access to this repo and cannot be achieved with a PR.
The pypi API token is encrypted through |
|
/lgtm |
|
Tested again with tag I'm going to create an experimental branch to test with a real semver generated (v0.0.0a1) |
|
I experimented in this branch. v0.0.0a2 was deployed to pypi successfully in this job. The py34 job failed because some installation requires py35+. The remaining jobs in the build skipped pypi deploy because v0.0.0a2 existed already |
|
I have tested the package by running https://github.com/kubernetes-client/python/blob/master/examples/out_of_cluster_config.py against Python 2.7, 3.4, 3.5, 3.6, 3.7 and 3.8. The build failure on Py3.4 will be handled when I push the multi stage build pipeline. |
|
For further improvements it may make sense to move the deploy step into a separate stage, so that it will only run if all prior tests pass. We could also add an early validation stage that will fail out if a non-semver tag is set, to catch a malformed tag |
The pypi deployment was failing with
even though it reported
Authenticated as kubernetesin an earlier step. I couldn't find a way to enable--verbosethrough travis.I issued a new pypi api token and re-encrypted it as a travis token. I also added some minor changes. Let's see if they help this time.
/cc @fabianvf @palnabarun