8000 Release 11.0.0 stable client by palnabarun · Pull Request #1050 · kubernetes-client/python · GitHub
[go: up one dir, main page]
Skip to content

Release 11.0.0 stable client #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

Release 11.0.0 stable client #1050

wants to merge 6 commits into from

Conversation

palnabarun
Copy link
Member

Updates version constants and re-generates the client

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: palnabarun
To complete the pull request process, please assign yliaog
You can assign the PR to them by writing /assign @yliaog in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 9, 2020
@palnabarun
Copy link
Member Author

/cc @roycaihw

@k8s-ci-robot k8s-ci-robot requested a review from roycaihw January 9, 2020 05:35
@palnabarun
Copy link
Member Author

/assign

@palnabarun
Copy link
Member Author

/cc @yliaog

@k8s-ci-robot k8s-ci-robot requested review from yliaog and micw523 January 9, 2020 05:36
@palnabarun
Copy link
Member Author

@roycaihw I had a doubt, should I have merged master to the release-11.0 branch so as to get the latest fixes from master?

@palnabarun palnabarun mentioned this pull request Jan 9, 2020
Merged
2 tasks
@micw523
Copy link
Contributor
micw523 commented Jan 9, 2020

I think he usually uses fast forward merge?

@micw523
Copy link
Contributor
micw523 commented Jan 9, 2020

Also, if there are base repo changes that haven't been brought in yet, it could be a good idea to do that as well.

@palnabarun
Copy link
Member Author

Also, if there are base repo changes that haven't been brought in yet, it could be a good idea to do that as well.

I checked out the base repo changes when I generated the client. I will check once more just to be extra sure.

@palnabarun
Copy link
Member Author

I think he usually uses fast forward merge?

I also saw that for the earlier releases. Wasn't sure whether to do it.

@roycaihw
Copy link
Member

should I have merged master to the release-11.0 branch so as to get the latest fixes from master?

If we detected bugs in the pre-releases (alpha & beta) and fixed them in master, you can update the pre-release branch by doing https://github.com/kubernetes-client/python/blob/master/devel/release.md#update-pre-release-branch.

@palnabarun
Copy link
Member Author

@roycaihw Thanks for pointing that out.

@palnabarun
Copy link
Member Author

One more doubt I had, if there are changes in the repo, where should the changelog's be committed? This PR or the PR which targets master?

@roycaihw
Copy link
Member

palnabarun wants to merge 6 commits into kubernetes-client:master from palnabarun:release-11.0

It looks like this PR still targets the master branch. Perhaps you need to open a new PR to change that

if there are changes in the repo, where should the changelog's be committed

If there are API changes, the client needs to be re-generated and release notes should be collected in the master branch first. Then the new client and the release notes will be pulled into the release branch. So they are mostly in sync.

@palnabarun
Copy link
Member Author

Closing this PR and filing a new one.

@palnabarun palnabarun closed this Jan 16, 2020
@palnabarun palnabarun deleted the release-11.0 branch January 16, 2020 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roycaihw roycaihw Awaiting requested review from roycaihw

@yliaog yliaog Awaiting requested review from yliaog

@micw523 micw523 Awaiting requested review from micw523

Assignees

@palnabarun palnabarun

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@palnabarun @k8s-ci-robot @micw523 @roycaihw
0