8000 Remove GCE references from service-access-application-cluster.md by codenrhoden · Pull Request #8765 · kubernetes/website · GitHub
[go: up one dir, main page]

Skip to content

Remove GCE references from service-access-application-cluster.md #8765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2018

Conversation

codenrhoden
Copy link
Contributor

Remove links and references that are GCE specific. (#8764)

Took a stab at this good for first committers issue. Only question I would have is if it is still appropriate to keep the gcloud example when listing public IPs. I believe that it is.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2018
@k8sio-netlify-preview-bot
Copy link
Collaborator
k8sio-netlify-preview-bot commented May 25, 2018

Deploy preview for kubernetes-io-master-staging ready!

Built with commit abfa7e8

https://deploy-preview-8765--kubernetes-io-master-staging.netlify.com

Remove links and references that are GCE specific. (kubernetes#8764)
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 25, 2018
@@ -101,15 +101,12 @@ provides load balancing for an application that has two running instances.
see the node address by running `kubectl cluster-info`. If you are
using Google Compute Engine instances, you can use the
`gcloud compute instances list` command to see the public addresses of your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This gcloud command is still GCE specific but it is fine the leave it here because it is just an example of how to get public addesses.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we just gave the Kubernetes-specific way before, we don't need the GCE way. They can get that from the GCE docs. @Bradamant3 do you have thoughts?

Copy link
Contributor
@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2018
@zacharysarah
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2018< A886 /relative-time>
@k8s-ci-robot k8s-ci-robot merged commit e690ca4 into kubernetes:master Jun 6, 2018
@codenrhoden codenrhoden deleted the remove-gce-refs branch June 6, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
0