-
Notifications
You must be signed in to change notification settings - Fork 14.8k
Remove GCE references from service-access-application-cluster.md #8765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for kubernetes-io-master-staging ready! Built with commit abfa7e8 https://deploy-preview-8765--kubernetes-io-master-staging.netlify.com |
Remove links and references that are GCE specific. (kubernetes#8764)
5a86293
to
abfa7e8
Compare
@@ -101,15 +101,12 @@ provides load balancing for an application that has two running instances. | |||
see the node address by running `kubectl cluster-info`. If you are | |||
using Google Compute Engine instances, you can use the | |||
`gcloud compute instances list` command to see the public addresses of your |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This gcloud
command is still GCE specific but it is fine the leave it here because it is just an example of how to get public addesses.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think since we just gave the Kubernetes-specific way before, we don't need the GCE way. They can get that from the GCE docs. @Bradamant3 do you have thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zacharysarah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove links and references that are GCE specific. (#8764)
Took a stab at this good for first committers issue. Only question I would have is if it is still appropriate to keep the
gcloud
example when listing public IPs. I believe that it is.