[ja] Translate kms-provider.md into Japanese #51690
Conversation
|
Welcome @laxman-gupta1006! |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for your contribution! /area localization |
51c5453 to
ade32dd
Compare
There was a problem hiding this comment.
@laxman-gupta1006 I reveiwed half of the article.
I really appreciate your context-awared translation but your PR still contains several violations to the translation style guide.
I'll make review for the residual portion after your fixation at this point.
PTAL: https://kubernetes.io/ja/docs/contribute/localization
Also see #51690 (comment) .
| `DecryptRequest`プロシージャーコールは、`EncryptRequest`からの`(ciphertext, key_id, annotations)`と | ||
| ログ目的のUIDを提供します。期待される通り、これは`EncryptRequest`呼び出しの逆です。プラグインは | ||
| `key_id`が理解できるものであることを検証する必要があります - 以前の時点で自分が暗号化したデータであることを確信していない限り、 | ||
| データの復号化を試みてはいけません。 |
There was a problem hiding this comment.
| `DecryptRequest`プロシージャーコールは、`EncryptRequest`からの`(ciphertext, key_id, annotations)`と | 8000|
| ログ目的のUIDを提供します。期待される通り、これは`EncryptRequest`呼び出しの逆です。プラグインは | |
| `key_id`が理解できるものであることを検証する必要があります - 以前の時点で自分が暗号化したデータであることを確信していない限り、 | |
| データの復号化を試みてはいけません。 | |
| `DecryptRequest`プロシージャーコールでは、`EncryptRequest`から得た`(ciphertext, key_id, annotations)`とログ目的のUIDを提供します。 | |
| 期待される通り、これは`EncryptRequest`呼び出しの逆です。 | |
| プラグインは`key_id`が既知のものかどうかを検証しなければなりません(MUST)。 | |
| また、プラグインは自身が以前に暗号化したデータであることを確証できない限り、データの復号を試みてはいけません(MUST NOT)。 |
But I wonder why this sentence says:
(ciphertext, key_id, annotations)fromEncryptRequest
because these fields are owned by EncryptResponse and only be given by EncryptResponse.
I think that the first sentence of the original article is incorrect and original document should be fixed.
HDYT about that?
original:
The
DecryptRequestprocedure call provides the(ciphertext, key_id, annotations)fromEncryptRequestand a UID for logging purposes.
There was a problem hiding this comment.
I think that the first sentence of the original article is incorrect and original document should be fixed.
Although this data is indeed included in EncryptResponse, I think this sentence is fine as it is.
Because the data is obtained through the processing of EncryptRequest.
|
@g1eng I have made the changes you requested in commit ab95c4a. Please review when you have a chance. |
|
@laxman-gupta1006 Thanks! |
|
Hi. I've reviewed your PR again. @laxman-gupta1006 Please take a look at the code, especially for the rule of newlines after By the way, I've had lower back injury (herniated disc) and cannot move my body enough for current works. If you have any questions about the style guide, feel free to ask me or other sig/org members. |
|
Hi @g1eng , Thank you for the feedback! The changes have been committed here: 10d0323 Also, I hope you recover soon from your back injury, please don’t worry about prioritizing the review, and I’m fine waiting or proceeding with other reviewers as needed. |
|
@laxman-gupta1006 Thanks. I'll provide feedbacks in another day. |
|
/cc g1eng Big thank you for your review, Can you please take a look again to move this PR with forward |
|
First of all, thank you for your interest in the Japanese localization project. To reduce minor/nit comments, please follow our style guide - https://kubernetes.io/ja/docs/contribute/localization/#style-guide Thanks again |
Applied suggestions from code review Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com> Co-authored-by: youmeim <83828177+g1eng@users.noreply.github.com>
|
LGTM label has been added. Git tree hash: 01d4ee85238017632afde2b23a7b39afe36ce989
|
|
Regarding this comment, if the original document needs to be fixed, we will update the Japanese page later. /assign Okabe-Junya |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Okabe-Junya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* [ja] Translate kms-provider.md into Japanese * Remove reviewers field from Japanese translation metadata * Localize placeholder text and remove legacy hyperlinks in Japanese KMS provider docs * Fix Japanese localization style guide violations in KMS provider docs * Refactor KMS provider documentation for clarity and readability * Improve Japanese language flow and formatting * Changed notations * Apply suggestions from code review Applied suggestions from code review Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com> Co-authored-by: youmeim <83828177+g1eng@users.noreply.github.com> --------- Co-authored-by: inukai <82919057+t-inu@users.noreply.github.com> Co-authored-by: youmeim <83828177+g1eng@users.noreply.github.com>
Description
This PR provides a complete Japanese translation of the KMS provider documentation ([kms-provider.md] to improve accessibility for Japanese-speaking Kubernetes users. The translation maintains technical accuracy while preserving all code examples, YAML configurations, Hugo shortcodes, and markdown structure. All technical terminology is appropriately translated following existing Japanese documentation conventions in the repository.
File added: [kms-provider.md]
This translation is added to the Japanese documentation tree under the administration cluster tasks section, following the same structure as the English documentation.
Issue
Closes: #51634