-
Notifications
You must be signed in to change notification settings - Fork 15.1k
fix(typo): Update sidecar-containers.md #49799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
@corneliusroemer, thanks for the update on the PR, but seems like you have missed the description section of the PR. |
As this PR does not have any issues attached to it would be beneficial for if there is a description of the changes has been mentioned. |
@utkarsh-singh1 I've added a description, I hope I don't need to write an essay for a typo/grammar fix 😀 |
@corneliusroemer, Small description will only help your PR get better understanding across the reviewers, even if the changes are small. |
Looks good. If there are any other typos you can fix in this file while you're at it, that would be great. But this is a valid correction. /lgtm |
LGTM label has been added. Git tree hash: 9449d149df52dd67ccac834e110e1d50e1632e1d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fix common grammar error "effecting" -> "affecting"
See e.g. https://www.merriam-webster.com/grammar/affect-vs-effect-usage-difference