8000 fix(typo): Update sidecar-containers.md by corneliusroemer · Pull Request #49799 · kubernetes/website · GitHub
[go: up one dir, main page]

Skip to content

Conversation

corneliusroemer
Copy link
Contributor
@corneliusroemer 8000 corneliusroemer commented Feb 17, 2025

Fix common grammar error "effecting" -> "affecting"

See e.g. https://www.merriam-webster.com/grammar/affect-vs-effect-usage-difference

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 17, 2025
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2025
Copy link
netlify bot commented Feb 17, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit e8af0e5
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67b28affd667a30008b01125
😎 Deploy Preview https://deploy-preview-49799--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@utkarsh-singh1
Copy link
8000
Contributor
utkarsh-singh1 commented Feb 17, 2025

@corneliusroemer, thanks for the update on the PR, but seems like you have missed the description section of the PR.

@utkarsh-singh1
Copy link
Contributor

As this PR does not have any issues attached to it would be beneficial for if there is a description of the changes has been mentioned.

@corneliusroemer
Copy link
Contributor Author

@utkarsh-singh1 I've added a description, I hope I don't need to write an essay for a typo/grammar fix 😀

@utkarsh-singh1
Copy link
Contributor

@corneliusroemer, Small description will only help your PR get better understanding across the reviewers, even if the changes are small.

@stmcginnis
Copy link
Contributor

Looks good. If there are any other typos you can fix in this file while you're at it, that would be great. But this is a valid correction.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 18, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9449d149df52dd67ccac834e110e1d50e1632e1d

Copy link
Member
@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2b7d170 into kubernetes:main Feb 19, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0