10BC0 Modify `node-hello` image to `hello-app` by shayaniox · Pull Request #46582 · kubernetes/website · GitHub
[go: up one dir, main page]
Skip to content

Modify node-hello image to hello-app #46582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2024
Merged

Modify node-hello image to hello-app #46582

merged 1 commit into from
Jun 1, 2024

Conversation

shayaniox
Copy link
Contributor
@shayaniox shayaniox commented May 29, 2024 •
edited
Loading

This pull request aims to fix the error raised by pulling the image gcr.io/google-samples/node-hello:1.0 that says:

[DEPRECATION NOTICE] Docker Image Format v1 and Docker Image manifest version 2, schema 1 support is disabled by default and will be removed in an upcoming release. Suggest the author of gcr.io/google-samples/node-hello:1.0 to upgrade the image to the OCI Format or Docker Image manifest v2, schema 2. More information at https://docs.docker.com/go/deprecated-image-specs/

The pull request modifies the image node-hello to hello-app, so the error will be fixed.

Moreover, the tutorial in the other languages is revised.

The documentation is modified by the following groups:

  • tutorial:
    1. stateless application -> exposing external IP address
  • task:
    1. extend kubernetes
    2. manage kubernetes objects
  • pod:
    1. inject
    2. security
    3. service

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented May 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: shayaniox / name: shayan (fe08655)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 29, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @shayan-7!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/localization General issues or PRs related to localization labels May 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from ariscahyadi May 29, 2024 19:03
@k8s-ci-robot k8s-ci-robot added the language/bn Issues or PRs related to Bengali language label May 29, 2024
@k8s-ci-robot k8s-ci-robot requested a review from dipesh-rawat May 29, 2024 19:03
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 29, 2024
@netlify Netlify
Copy link
netlify bot commented May 29, 2024 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fe08655
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/665a1a0c5beec70008d8f2a2
😎 Deploy Preview https://deploy-preview-46582--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 29, 2024
dipesh-rawat
dipesh-rawat reviewed May 29, 2024
View reviewed changes
Copy link
Member
@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shayan-7 Thanks for your contribution. It seems this pull request involves changes to sample files in various languages: English, Italian, French, Japanese, Korean, and Chinese. However, our documentation follows distinct procedures for each localization, and we usually don’t approve pull requests that affect multiple languages at once. I suggest focusing solely on modifying the primary website content (which pertains to English only) with this pull request initially. Once the English content is merged, we can then create separate pull requests for the other language(s). I hope this suggestion is helpful.

@dipesh-rawat
Copy link
Member

Explicit hold until this PR only covers one language.
(Ok to unhold once that's done)
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2024
@shayaniox
Copy link
Contributor Author

@dipesh-rawat Thanks for the comment. I'd prune the changes to other languages.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 29, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2024
@shayaniox shayaniox changed the title Modify node-hello image to hello-app for stateless-application expose-external-ip-address tutorial Draft: Modify node-hello image to hello-app for stateless-application expose-external-ip-address tutorial May 29, 2024
@shayaniox shayaniox changed the title Modify node-hello image to hello-app for stateless-application expose-external-ip-address tutorial Modify node-hello image to hello-app May 29, 2024
@shayaniox shayaniox requested a review from dipesh-rawat May 29, 2024 20:25
@steve-hardman
Copy link
Contributor

/remove-language bn id ja ko zh

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed language/bn Issues or PRs related to Bengali language language/id Issues or PRs related to Indonesian language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/zh Issues or PRs related to Chinese language labels May 29, 2024
@steve-hardman
Copy link
Contributor

There is now only 'en' file so good tro unhold.

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 30, 2024
@tengqm
Copy link
Contributor
tengqm commented May 30, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2024
@tengqm tengqm added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 30, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2024
@shayaniox shayaniox closed this May 31, 2024
@shayaniox shayaniox reopened this Jun 1, 2024
@shayaniox
Copy link
Contributor Author
shayaniox commented Jun 1, 2024 •
edited
Loading

@tengqm @dipesh-rawat Could you determine state of the pull request?

@tengqm
Copy link
Contributor
tengqm commented Jun 1, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 95e2b1f2596d0a0a75994f0cfbf5c166208363eb

@k8s-ci-robot k8s-ci-robot merged commit d5b194d into kubernetes:main Jun 1, 2024
AnshumanTripathi pushed a commit to AnshumanTripathi/kubernetes-website that referenced this pull request Jun 10, 2024
@shayaniox @AnshumanTripathi
Modify the image node-hello to hello-app (kubernetes#46582)
26624fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariscahyadi ariscahyadi Awaiting requested review from ariscahyadi

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shayaniox @k8s-ci-robot @dipesh-rawat @steve-hardman @tengqm
0