E54B Remove gwapi crd validation precommit job by rikatz · Pull Request #35208 · kubernetes/test-infra · GitHub
[go: up one dir, main page]
Skip to content

Remove gwapi crd validation precommit job #35208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2025
Merged

Remove gwapi crd validation precommit job #35208

merged 1 commit into from
Jul 24, 2025

Conversation

rikatz
Copy link
Member
@rikatz rikatz commented Jul 24, 2025 •
edited
Loading

The CRD Validation precommit jobs were moved to Github actions and are using envtest now.

This way, the precommit jobs on Prow for CRD/CEL validation can be removed

Ref.: kubernetes-sigs/gateway-api#3948

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from aojea and bowei July 24, 2025 20:55
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 24, 2025
@rikatz
Copy link
Member Author
rikatz commented Jul 24, 2025

/cc @robscott @shaneutt @youngnick

@rikatz rikatz force-pushed the remove-precommit-crd branch from 1c25efa to 7b96715 Compare July 24, 2025 21:05
@robscott
Copy link
Member

Thanks @rikatz!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 24, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 24, 2025
@k8s-ci-robot k8s-ci-robot merged commit f143c47 into kubernetes:master Jul 24, 2025
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@rikatz: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gateway-api-config.yaml using file config/jobs/kubernetes-sigs/gateway-api/gateway-api-config.yaml

In response to this:

The CRD Validation precommit jobs were moved to Github actions and are using envtest now.

This way, the precommit jobs on Prow for CRD/CEL validation can be removed

Ref.: kubernetes-sigs/gateway-api#3948

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea Awaiting requested review from aojea

@bowei bowei Awaiting requested review from bowei

@robscott robscott Awaiting requested review from robscott

@shaneutt shaneutt Awaiting requested review from shaneutt

@youngnick youngnick Awaiting requested review from youngnick

Assignees

@robscott robscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rikatz @robscott @k8s-ci-robot
0