Cherry pick of #98254:Fix the kube-scheduler binary's description of … #98786
Conversation
|
@changshuchao: This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hi @changshuchao. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/assign @alculquicondor |
|
/ok-to-test |
…iption of the --config parameter is inaccurate Signed-off-by: changshuchao <chang.shuchao1@zte.com.cn>
|
/lgtm |
|
@kubernetes/release-managers /retest |
There was a problem hiding this comment.
@alculquicondor I believe this would also be applicable to 1.19 and 1.18. If so, can we go ahead and get CPs on those branches and get them all in together?
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, changshuchao, hasheddan, wzshiming The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alculquicondor Sorry, can this pr be merged? |
|
@changshuchao if this cherry pick is also applicable to 1.19 and 1.18 we need to have those open and merge them all at the same time. It appears to me that it is applicable, but could you confirm if it is not? |
|
@hasheddan well，i got your point. i'll check it out |
|
@hasheddan I don't think this change is suitable for 1.18 branch, but 1.19 is ok, link:#98873. |
|
why do they need to merge at the same time? We need a different code-review for 1.19, as parameter deprecation might have been different. |
|
@alculquicondor we prefer to merge all at the same time so that the fixes go out in the same round of patch releases. It can be unexpected for users to consume patch releases where a fix is applicable to multiple minor versions but is only included in the patch for one of them. |
|
/sig scheduling |
|
/remove-sig scheduling |
|
/sig sheduling |
|
@alculquicondor: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/sig scheduling |
|
/retest |
Cherry pick of #98254 on release-1.20.
#98254:Fix the kube-scheduler binary's description of the --config parameter is inaccurate
Does this PR introduce a user-facing change?: