8000 Graduating Windows GMSA support to beta by wk8 · Pull Request #82110 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

Graduating Windows GMSA support to beta #82110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2019
Merged

Graduating Windows GMSA support to beta #82110

merged 1 commit into from
Aug 30, 2019

Conversation

wk8
Copy link
Contributor
@wk8 wk8 commented Aug 29, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Concerns from alpha-phase reviews have been addressed in
#80320
and
#82109
and early adopters have given positive feedback; so it seems there are
no blockers to graduate GMSA support to beta.

This patch also enables GMSA support by default, mainly for the sake of
making it easier for cluster admins to use, as well as for e2e tests in
nightly builds.

Does this PR introduce a user-facing change?:

Graduating Windows GMSA support from alpha to beta

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/20181221-windows-group-managed-service-accounts-for-container-identity.md

@wk8
Graduating Windows GMSA support to beta
4607b4b 
Concerns from alpha-phase reviews have been addressed in
kubernetes#80320
and
kubernetes#82109
and early adopters have given positive feedback; so it seems there are
no blockers to graduate GMSA support to beta.

This patch also enables GMSA support by default, mainly for the sake of
making it easier for cluster admins to use, as well as for e2e tests in
nightly builds.

Signed-off-by: Jean Rouge <rougej+github@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 29, 2019
@wk8
Copy link
Contributor Author
wk8 commented Aug 29, 2019

/hold
until #82109 is merged

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@wk8
Copy link
Contributor Author
wk8 commented Aug 29, 2019

/priority important-soon
/sig windows

8000
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 29, 2019
@ddebroy
Copy link
Contributor
ddebroy commented Aug 29, 2019

/assign @michmike @PatrickLang @brendanburns

@k8s-ci-robot
Copy link
Contributor

@ddebroy: GitHub didn't allow me to assign the following users: brendanburns.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @michmike @PatrickLang @brendanburns

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@michmike
Copy link
Contributor

/approve
/Lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 29, 2019
@wk8
Copy link
Contributor Author
wk8 commented Aug 29, 2019

/test pull-kubernetes-e2e-gce

@PatrickLang
Copy link
Contributor

/milestone v1.16

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 29, 2019
@ddebroy ddebroy mentioned this pull request Aug 29, 2019
Closed
@PatrickLang
Copy link
Contributor

/lgtm
/approve

Will remove hold in a bit once #82109 is in tide pool

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michmike, PatrickLang, wk8

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatrickLang
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot merged commit 96a1558 into kubernetes:master Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@michmike michmike

@PatrickLang PatrickLang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
5 participants
@wk8 @ddebroy @k8s-ci-robot @michmike @PatrickLang
0