10BC0 Automated cherry pick of #60872: purge all the -v references from e2e.go by krzyzacy · Pull Request #60941 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

Automated cherry pick of #60872: purge all the -v references from e2e.go #60941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2018
Merged

Automated cherry pick of #60872: purge all the -v references from e2e.go #60941

merged 1 commit into from
Mar 13, 2018

Conversation

krzyzacy
Copy link
Member
@krzyzacy krzyzacy commented Mar 8, 2018

Cherry pick of #60872 on release-1.8.

#60872: purge all the -v references from e2e.go

@k8s-ci-robot
Copy link
Contributor

@krzyzacy: All 'parent' PRs of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement.

The following parent PRs have neither the "release-note" nor the "release-note-action-required" labels: #60872.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 8, 2018
@k8s-ci-robot
Copy link
Contributor

@krzyzacy: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Mar 8, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 8, 2018
@k8s-ci-robot k8s-ci-robot requested review from ixdy and shyamjvs March 8, 2018 19:21
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 8, 2018
@krzyzacy
Copy link
Member Author
krzyzacy commented Mar 8, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 8, 2018
@ixdy
Copy link
Contributor
ixdy commented Mar 8, 2018

should we be cherry-picking this? or waiting for #60895 and cherry-picking it? cc @BenTheElder

shyamjvs
shyamjvs reviewed Mar 8, 2018
View reviewed changes
build/root/Makefile
else
test-e2e: ginkgo generated_files
go run hack/e2e.go -- -v --build --up --test --down
go run hack/e2e.go -- --build --up --test --down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw - don't we want to have --verbose-commands instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's default now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that was done in kubernetes/test-infra#5452

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.. thanks

@shyamjvs
Copy link
Member
shyamjvs commented Mar 8, 2018

/lgtm

/assign @jpbetz
(PRM for 1.8)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2018
@krzyzacy
Copy link
Member Author
krzyzacy commented Mar 8, 2018

@ixdy maybe both, as that PR hasn't went in yet, I'd at least unbork branch presubmits

@ixdy
Copy link
Contributor
ixdy commented Mar 8, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, krzyzacy, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2018
@ixdy
Copy link
Contributor
ixdy commented Mar 8, 2018

/retest

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 12, 2018
@BenTheElder
Copy link
Member

/retest

@krzyzacy
Copy link
Member Author

lol we probably should cherrypick that testCRD timeout fix as well :-)
/retest

cc @jennybuckley

@BenTheElder
Copy link
Member

@krzyzacy this needs a milestone

@krzyzacy
Copy link
Member Author

/milestone v1.8

@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Mar 13, 2018
@krzyzacy
Copy link
Member Author

/kind bug
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Mar 13, 2018
@liggitt
Copy link
Member
liggitt commented Mar 13, 2018

/status approved-for-milestone

@liggitt
Copy link
Member
liggitt commented Mar 13, 2018

/sig testing

@k8s-ci-robot k8s-ci-robot added the sig/testing Categorizes an issue or PR as relevant to SIG Testing. label Mar 13, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@ixdy @jpbetz @krzyzacy @shyamjvs

Pull Request Labels
  • sig/testing: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@liggitt liggitt mentioned this pull request Mar 13, 2018
Merged
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@liggitt
Copy link
Member
liggitt commented Mar 13, 2018

/retest

@jennybuckley jennybuckley mentioned this pull request Mar 13, 2018
Merged
@jennybuckley
Copy link

@krzyzacy should #60458 be cherry-picked to 1.7 as well?

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit e7dc539 into kubernetes:release-1.8 Mar 13, 2018
@krzyzacy krzyzacy deleted the automated-cherry-pick-of-#60872-upstream-release-1.8 branch March 13, 2018 17:56
@krzyzacy
Copy link
Member Author

@jennybuckley when is the problematic change introduced? depend if that's before 1.7 or not

@jennybuckley
Copy link
jennybuckley commented Mar 13, 2018 •
edited
Loading

@krzyzacy Actually, I think the flakiness of TestCRD was caused by #57521 which was made in 1.10 so we don't necessarily need to cherry pick it, unless that change gets cherry picked also.
Before that change, the incorrect timeout value set in test-dockerized.sh was just being overwritten by the default (which was the correct value).

@MikeSpreitzer MikeSpreitzer mentioned this pull request Mar 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ixdy ixdy Awaiting requested review from ixdy

1 more reviewer

@shyamjvs shyamjvs shyamjvs left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jpbetz jpbetz

@shyamjvs shyamjvs

@ixdy ixdy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

9 participants

@krzyzacy @k8s-ci-robot @ixdy @shyamjvs @BenTheElder @liggitt @k8s-github-robot @jennybuckley @jpbetz
0