8000 Automated cherry pick of #132040: Make nodeports scheduling plugin restartable initContainer aware by SergeyKanzhelev · Pull Request #133390 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

Automated cherry pick of #132040: Make nodeports scheduling plugin restartable initContainer aware #133390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2025
Merged

Automated cherry pick of #132040: Make nodeports scheduling plugin restartable initContainer aware #133390

merged 1 commit into from
Oct 10, 2025
+1,084 −157

Conversation

SergeyKanzhelev
Copy link
Member
@SergeyKanzhelev SergeyKanzhelev commented Aug 5, 2025 •
edited
Loading

Cherry pick of #132040 on release-1.33.

#132040: Make nodeports scheduling plugin restartable initContainer aware

For details on the cherry pick process, see the cherry pick requests page.

Fixes #132037

Extends the nodeports scheduling plugin to consider hostPorts used by restartable init containers.

@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Aug 5, 2025
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 5, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Aug 5, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: SergeyKanzhelev / name: Sergey Kanzhelev (15693e0)

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. area/test labels Aug 5, 2025
@k8s-ci-robot k8s-ci-robot requested review from denkensk and macsko August 5, 2025 20:29
@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 5, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 5, 2025
@SergeyKanzhelev
Copy link
Member Author

This is a result of hack/cherry_pick_pull.sh upstream/release-1.33 132040 One conflct was resolved manually.

/kind bug
/priority important-soon

/cc @avrittrohwer

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: GitHub didn't allow me to request PR reviews from the following users: avrittrohwer.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

This is a result of hack/cherry_pick_pull.sh upstream/release-1.33 132040 One conflct was resolved manually.

/kind bug
/priority important-soon

/cc @avrittrohwer

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 5, 2025
@SergeyKanzhelev
Copy link
Member Author

/check-cla

@SergeyKanzhelev SergeyKanzhelev force-pushed the automated-cherry-pick-of-#132040-upstream-release-1.33 branch 2 times, most recently from e36e01e to a96e43d Compare August 5, 2025 21:09
@SergeyKanzhelev SergeyKanzhelev force-pushed the automated-cherry-pick-of-#132040-upstream-release-1.33 branch from a96e43d to 15693e0 Compare August 5, 2025 21:13
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 5, 2025
@SergeyKanzhelev
Copy link
Member Author

/retest

@macsko
Copy link
Member
macsko commented Sep 4, 2025

/approve
scheduler

@SergeyKanzhelev
Copy link
Member Author

/assign @cblecker

as per bot recommendation

@cblecker
Copy link
Member
cblecker commented Sep 5, 2025

/approve
for test/

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2025
@SergeyKanzhelev
Copy link
Member Author

/cc kubernetes/release-managers

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Sep 9, 2025
Open
matthyx
matthyx approved these changes Sep 10, 2025
View reviewed changes
Copy link
Contributor
@matthyx matthyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4b502b417f335f719fa8e357647b915dca5905ba

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, macsko, matthyx, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helayoty helayoty moved this to Needs Review in SIG Scheduling Sep 10, 2025
@helayoty helayoty moved this from Needs Review to Needs Final Approver in SIG Scheduling Sep 10, 2025
@SergeyKanzhelev
Copy link
Member Author

/cc kubernetes/release-managers

Verolop
Verolop reviewed Oct 10, 2025
View reviewed changes
Copy link
@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Verolop Verolop added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 10, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Oct 10, 2025
@Verolop
Copy link
Verolop commented Oct 10, 2025

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit ae85505 into kubernetes:release-1.33 Oct 10, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this from Needs Final Approver to Done in SIG Scheduling Oct 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Verolop Verolop Verolop left review comments

@denkensk denkensk Awaiting requested review from denkensk

@macsko macsko Awaiting requested review from macsko

+1 more reviewer

@matthyx matthyx matthyx approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@cblecker cblecker

@Verolop Verolop

@matthyx matthyx

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

SIG Scheduling
Status: Done

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

6 participants

@SergeyKanzhelev @k8s-ci-robot @macsko @cblecker @Verolop @matthyx
0