8000 Apply fix to namespace deletion test by fedebongio · Pull Request #132691 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

Apply fix to namespace deletion test #132691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 3, 2025
Merged

Apply fix to namespace deletion test #132691

merged 3 commits into from
Jul 3, 2025

Conversation

fedebongio
Copy link
Contributor

What type of PR is this?

/kind bug
/kind flake

What this PR does / why we need it:

Which issue(s) this PR is related to:

#132687
#132219

Special notes for your reviewer:

Worked with @aojea guidance on this change

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from cheftako and liggitt July 2, 2025 18:30
@fedebongio
Copy link
Contributor Author

cc @BenTheElder

@BenTheElder
8000 Copy link
Member

hmm, seems we got a new flake in the test?
https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/132691/pull-kubernetes-e2e-kind/1940478127268433920

@aojea
Copy link
Member
aojea commented Jul 2, 2025

hmm, seems we got a new flake in the test? https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/132691/pull-kubernetes-e2e-kind/1940478127268433920

hehe cursed test


Kubernetes e2e suite: [It] [sig-api-machinery] OrderedNamespaceDeletion namespace deletion should delete pod first [FeatureGate:OrderedNamespaceDeletion] expand_less | 3m8s
-- | --
{ failed [FAILED] Timed out after 180.000s. The function passed to Eventually returned the following error:     <framework.transientError>:      pods "test-pod" not found     {         error: <*errors.StatusError \| 0xc002d0ac80>{             ErrStatus: {                 TypeMeta: {Kind: "", APIVersion: ""},                 ListMeta: {                     SelfLink: "",                     ResourceVersion: "",                     Continue: "",                     RemainingItemCount: nil,                 },                 Status: "Failure",                 Message: "pods \"test-pod\" not found",                 Reason: "NotFound",                 Details: {Name: "test-pod", Group: "", Kind: "pods", UID: "", Causes: nil, RetryAfterSeconds: 0},                 Code: 404,             },         },     } In [It] at: k8s.io/kubernetes/test/e2e/apimachinery/namespace.go:617 @ 07/02/25 18:50:09.496

aojea
aojea reviewed Jul 2, 2025
View reviewed changes
fedebongio and others added 2 commits July 2, 2025 15:11
@fedebongio @aojea
Update test/e2e/apimachinery/namespace.go
9e2ec6b 
Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
@fedebongio
Update namespace.go
65910e6 
oops
@fedebongio
Copy link
Contributor Author

sorry for the noise, took antonio's suggestion and also fixed a syntax error. If it works well, I'll clean up / squash the commits or start a clean pr

@aojea
Copy link
Member
aojea commented Jul 3, 2025

/label tide-squash-merge

@k8s-ci-robot
Copy link
Contributor

@aojea: The label(s) /label tide-squash-merge cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full, official-cve-feed. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label tide-squash-merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@aojea
Copy link
Member
aojea commented Jul 3, 2025

/label tide/merge-method-squash
/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 3, 2025
@aojea
Copy link
Member
aojea commented Jul 3, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 170a788c05744c0c2803cf11a3d0c32b6406dc2a

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, fedebongio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@aojea
Copy link
Member
aojea commented Jul 3, 2025

unrelated


k8s.io/apiserver/pkg/endpoints: handlers expand_less | 0s
-- | --
{Failed  === RUN   TestPatchResourceTimeout     rest_test.go:460: Starting test TestPatchResourceTimeout     rest_test.go:508: Working with patchType application/json-patch+json     rest_test.go:508: Working with patchType application/merge-patch+json     rest_test.go:508: Working with patchType application/strategic-merge-patch+json     rest_test.go:606: TestPatchResourceTimeout: expected error Timeout: request did not complete within requested timeout - context deadline exceeded, but got context deadline exceeded --- FAIL: TestPatchResourceTimeout (0.00s)

/test pull-kubernetes-unit

@k8s-ci-robot k8s-ci-robot merged commit 43b22a2 into kubernetes:master Jul 3, 2025
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 3, 2025
drjackild pushed a commit to drjackild/kubernetes that referenced this pull request Jul 11, 2025
@fedebongio @aojea @drjackild
Apply fix to namespace deletion test (kubernetes#132691)
544c9a7 
* Apply fix to namespace deletion test

* Update test/e2e/apimachinery/namespace.go

Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>

* Update namespace.go

oops

---------

Co-authored-by: Antonio Ojea <antonio.ojea.garcia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aojea aojea aojea left review comments

@cheftako cheftako Awaiting requested review from cheftako

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@aojea aojea

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@fedebongio @k8s-ci-robot @BenTheElder @aojea
0