10000 DRA E2E: serialize costly test by pohly · Pull Request #132688 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

DRA E2E: serialize costly test #132688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

DRA E2E: serialize costly test #132688

merged 1 commit into from
Jul 3, 2025

Conversation

pohly
Copy link
Contributor
@pohly pohly commented Jul 2, 2025

What type of PR is this?

/kind cleanup
/kind failing-test
/kind flake

What this PR does / why we need it:

After enabling more tests in 00dd610, periodic ci-kind-dra-all became unstable, with random flakes at the time when the "supports sharing a claim sequentially". Probably the cluster became overwhelmed by the number of pods which wanted to run in parallel. Running this tests in the serial phase of a Ginkgo run should fix this.

Which issue(s) this PR is related to:

Failing:

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@pohly
DRA E2E: serialize costly test
ad0b2bf 
After enabling more tests in 00dd610,
periodic ci-kind-dra-all became unstable, with random flakes at the time when
the "supports sharing a claim sequentially". Probably the cluster became
overwhelmed by the number of pods which wanted to run in parallel. Running this
tests in the serial phase of a Ginkgo run should fix this.
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 2, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. wg/device-management Categorizes an issue or PR as relevant to WG Device Management. labels Jul 2, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 2, 2025
@k8s-ci-robot k8s-ci-robot requested review from bart0sh and klueska July 2, 2025 16:16
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 2, 2025
@pohly pohly mentioned this pull request Jul 2, 2025
Merged
@pohly
Copy link
Contributor Author
pohly commented Jul 2, 2025

Depends on kubernetes/test-infra#35070 for testing.

8000
@pohly pohly mentioned this pull request Jul 2, 2025
Merged
@pohly
Copy link
Contributor Author
pohly commented Jul 2, 2025

/test pull-kubernetes-kind-dra-all-slow

@pohly
Copy link
Contributor Author
pohly commented Jul 2, 2025

https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/132688/pull-kubernetes-kind-dra-all-slow/1940481958467342336 succeeded, so this seems to help. Let's merge it and see how the periodic job reacts (should be identical, though).

@pohly pohly marked this pull request as ready for review July 2, 2025 19:44
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 2, 2025
@pohly
Copy link
Contributor Author
pohly commented Jul 2, 2025

/assign @bart0sh

@pacoxu
Copy link
Member
pacoxu commented Jul 3, 2025

/lgtm
/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8e1db24bcfd92e967bd81fc87af12758a7b383dd

@pacoxu pacoxu mentioned this pull request Jul 3, 2025
Closed
@k8s-ci-robot k8s-ci-robot merged commit 7f4f1c2 into kubernetes:master Jul 3, 2025
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Jul 3, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in SIG Node CI/Test Board Jul 3, 2025
@Rajalakshmi-Girish Rajalakshmi-Girish mentioned this pull request Jul 4, 2025
Closed
@pohly pohly moved this from 🆕 New to ✅ Done in Dynamic Resource Allocation Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@klueska klueska Awaiting requested review from klueska

Assignees

@pacoxu pacoxu

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: ✅ Done
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@pohly @k8s-ci-robot @pacoxu @bart0sh
0