[WIP] Validate OS not windows for PodLevelResources #132627
Open
+114
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reject Pod with PodLevelResources in spec if Pod targets Windows OS.
|
/sig node |
|
/assign @ndixita |
annasong20
commented
Jun 30, 2025
| if spec.OS != nil && spec.OS.Name == core.Windows { | ||
| // Do not include more detailed errors on the resources field value | ||
| // if the resources field cannot be set on the target OS. | ||
| return field.ErrorList{ |
There was a problem hiding this comment.
LMK if I should append the error instead.
|
/triage accepted |
|
/ok-to-test |
Reject pods with PodLevelResources in kubelet on nodes running Windows OS.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: annasong20 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
annasong20
commented
Jul 2, 2025
| @@ -1199,6 +1199,11 @@ func (m *kubeGenericRuntimeManager) SyncPod(ctx context.Context, pod *v1.Pod, po | |||
| podIPs = podStatus.IPs 8000 | |||
| } | |||
|
|
|||
| if isAllowed, msg := allocation.IsPodLevelResourcesAllowed(pod); pod.Spec.Resources != nil && !isAllowed { | |||
There was a problem hiding this comment.
@ndixita LMK if I should move this check somewhere else in the SyncPod method or add logs. I could alternatively define a SyncAction for PodLevelResources.
Once I clarify the behavior, I'll also need to figure out if I can find a _windows_test.go and _linux_test.go that calls SyncPod to test this behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reject Pod with PodLevelResources in spec if Pod targets Windows OS.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Adds check to
Which issue(s) this PR is related to:
Fixes #132582.
PodLevelResources KEP that documents this behavior: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/2837-pod-level-resource-spec/README.md#future-kep-consideration-in-135-support-for-windows.
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: