E53E Update to latest cadvisor @ v0.52.1 and new opencontainer/cgroups and drops opencontainers/runc by dims · Pull Request #130569 · kubernetes/kubernetes · GitHub
[go: up one dir, main page]
Skip to content

Update to latest cadvisor @ v0.52.1 and new opencontainer/cgroups and drops opencontainers/runc #130569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2025
Merged

Update to latest cadvisor @ v0.52.1 and new opencontainer/cgroups and drops opencontainers/runc #130569

merged 2 commits into from
Mar 8, 2025

Conversation

dims
Copy link
Member
@dims dims commented Mar 4, 2025

We need this so we can be on latest containerd, runc dependencies and more importantly pick up the newly minted github.com/opencontainers/cgroups which will help us move to decouple kubernetes from runc (almost there!)

What type of PR is this?

/kind cleanup
/area dependency

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/dependency Issues or PRs related to dependency changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 4, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Mar 4, 2025
@k8s-ci-robot k8s-ci-robot requested review from alexzielenski, andrewsykim and a team March 4, 2025 19:33
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/kube-proxy area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. labels Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Mar 4, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Mar 4, 2025
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. labels Mar 4, 2025
@dgrisonnet
Copy link
Member

/remove-sig instrumentation

@k8s-ci-robot k8s-ci-robot removed the sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. label Mar 6, 2025
@yongruilin
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 6, 2025
@bart0sh bart0sh moved this from not-only-sig-node to Triage in SIG Node: code and documentation PRs Mar 7, 2025
@bart0sh bart0sh moved this from Triage to not-only-sig-node in SIG Node: code and documentation PRs Mar 7, 2025
@kakkoyun
Copy link
kakkoyun commented Mar 7, 2025

Hey @dims we have the new release candidate https://github.com/prometheus/client_golang/releases/tag/v1.22.0-rc.0 with @liggitt's patch.

@dims
Copy link
Member Author
dims commented Mar 7, 2025

@kakkoyun thank you! updating this PR with the RC

@dims
Copy link
Member Author
dims commented Mar 7, 2025 •
edited
Loading

@kakkoyun @liggitt Something's wrong with the checksum database, i am seeing the following error:

$ hack/pin-dependency.sh github.com/prometheus/client_golang v1.22.0-rc.0
go: downloading go1.24.0 (linux/amd64)
Running: go mod download github.com/prometheus/client_golang@v1.22.0-rc.0
Download failed: github.com/prometheus/client_golang@v1.22.0-rc.0: verifying go.mod: github.com/prometheus/client_golang@v1.22.0-rc.0/go.mod: reading https://sum.golang.org/lookup/github.com/prometheus/client_golang@v1.22.0-rc.0: 404 Not Found
        server response:
        not found: github.com/prometheus/client_golang@v1.22.0-rc.0: invalid version: git ls-remote -q origin in /tmp/gopath/pkg/mod/cache/vcs/6ffa6057942360db9e438bbc1bc03e3efd3ae1d41df4abeb5328ef376a815bfa: exit status 128:
                fatal: unable to access 'https://github.com/prometheus/client_golang/': Failed to connect to github.com port 443: Connection refused

looking at https://sum.golang.org/lookup/github.com/prometheus/client_golang@v1.22.0-rc.0 i see the following:

not found: github.com/prometheus/client_golang@v1.22.0-rc.0: invalid version: git ls-remote -q origin in /tmp/gopath/pkg/mod/cache/vcs/6ffa6057942360db9e438bbc1bc03e3efd3ae1d41df4abeb5328ef376a815bfa: exit status 128:
	fatal: unable to access 'https://github.com/prometheus/client_golang/': Failed to connect to github.com port 443: Connection refused

hoping it's an intermittent thing. will try later today

xref: golang/go#72121

@dims
update to v1.22.0-rc.0
97a54dc 
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. labels Mar 7, 2025
@dims
Copy link
Member Author
dims commented Mar 7, 2025

/retest

@liggitt
Copy link
Member
liggitt commented Mar 7, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e265a21b969b43261fffdef2e8b888aca43bd4c9

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 0eaee48 into kubernetes:master Mar 8, 2025
18 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Mar 8, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed / Done in SIG Auth Mar 8, 2025
@github-project-automation github-project-automation bot moved this from Archive-it to Done in SIG Node CI/Test Board Mar 8, 2025
@github-project-automation github-project-automation bot moved this from not-only-sig-node to Done in SIG Node: code and documentation PRs Mar 8, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Mar 8, 2025
@kolyshkin kolyshkin mentioned this pull request Mar 9, 2025
Closed
7 tasks
@dims dims mentioned this pull request Mar 10, 2025
Closed
@roycaihw roycaihw mentioned this pull request Mar 10, 2025
Open
25 tasks
@aaron-prindle
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 11, 2025
akhilerm
akhilerm reviewed Mar 20, 2025
View reviewed changes
go.work.sum
cloud.google.com/go/clouddms v1.7.3 h1:xe/wJKz55VO1+L891a1EG9lVUgfHr9Ju/I3xh1nwF84=
cloud.google.com/go/cloudtasks v1.12.4 h1:5xXuFfAjg0Z5Wb81j2GAbB3e0bwroCeSF+5jBn/L650=
cloud.google.com/go/compute v1.25.1 h1:ZRpHJedLtTpKgr3RV1Fx23NuaAEN1Zfx9hw1u4aJdjU=
cloud.google.com/go/compute v1.23.3 h1:6sVlXXBmbd7jNX0Ipq0trII3e4n1/MsADLK6a+aiVlk=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know why the version of cloud.google.com/go/compute was downgraded?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't. Kubernetes doesn't vendor or link this dependency at all.

This file just records all the checksums of modules referenced anywhere in the dependency graph, including transitively. As transitive dependencies get dropped, versions of random transitively referenced dependencies can change like this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

< 57A7 span class="d-flex min-width-0 flex-1 js-hovercard-left" data-hovercard-type="user" data-hovercard-url="/users/liggitt/hovercard" data-assignee-name="liggitt"> @liggitt liggitt liggitt left review comments

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

+3 more reviewers

@pacoxu pacoxu pacoxu left review comments

@bwplotka bwplotka bwplotka left review comments

@akhilerm akhilerm akhilerm left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@liggitt liggitt

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Archived in project
SIG Auth
Archived in project
SIG CLI
Archived in project
SIG Node CI/Test Board
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.33
Development

Successfully merging this pull request may close these issues.
0